In components/autofill, move browser/ to core/browser/

In components/autofill, move browser/ to core/browser/

This change completes the large-scale restructuring of components/autofill into
its structure of a layered component.  This CL additionally imposes the correct
DEPS restrictions on autofill/components/core/browser/, with temporary
allowances for the current violating includes.

TBR=joi,benm,thakis,erikwright
BUG=247015
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207403

[blundell, 2013-06-18 20:30:18]

mass-rename.py followed by DEPS and gypfile fixup.

joi: CL as a whole + autofill and webdata OWNERS
benm: android_webview OWNERS
thakis: chrome OWNERS
erikwright: chrome_frame OWNERS (!)

[commit-bot: I haz the power, 2013-06-18 20:31:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/17392006/1

[Jói, 2013-06-18 20:45:01]

Looks like the patch didn't upload properly, or hasn't finished uploading.


On Tue, Jun 18, 2013 at 8:31 PM, <commit-bot@chromium.org> wrote:

> CQ is trying da patch. Follow status at
> https://chromium-status.**appspot.com/cq/blundell@**
>
chromium.org/17392006/1<https://chromium-status.appspot.com/cq/blundell@chromium.org/17392006/1>
>
>
>
https://chromiumcodereview.**appspot.com/17392006/<https://chromiumcodereview...
>

[commit-bot: I haz the power, 2013-06-18 20:48:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/17392006/18018

[blundell, 2013-06-18 20:48:30]

On 2013/06/18 20:45:01, Jói wrote:
> Looks like the patch didn't upload properly, or hasn't finished uploading.
> 
> 
> On Tue, Jun 18, 2013 at 8:31 PM, <mailto:commit-bot@chromium.org> wrote:
> 
> > CQ is trying da patch. Follow status at
> > https://chromium-status.**appspot.com/cq/blundell%40**
> >
>
chromium.org/17392006/1<https://chromium-status.appspot.com/cq/blundell@chromium.org/17392006/1>
> >
> >
> >
>
https://chromiumcodereview.**appspot.com/17392006/%3Chttps://chromiumcoderevi...>
> >

Should be good now.

[commit-bot: I haz the power, 2013-06-18 21:29:43]

Retried try job too often on win for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2013-06-18 21:48:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/17392006/18018

[Nico, 2013-06-18 21:52:29]

In which I add shareholder value (no really, there's a comment below).

In addition to that comment:
1.) All the other CLs had a BUG= line linking to a bug linking to your design
doc iirc. This CL should, too.
2.) I hope you're using tools/git/mass-rename.sh for this.

https://chromiumcodereview.appspot.com/17392006/diff/18018/chrome/browser/ui/...
File chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc (right):

https://chromiumcodereview.appspot.com/17392006/diff/18018/chrome/browser/ui/...
chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc:11: #include
"chrome/browser/ui/android/autofill/autofill_dialog_view_android.h"
This ain't right. Keep it at the top, but add an empty line below it.

[Jói, 2013-06-18 22:14:27]

Modulo fixes to thakis@'s comments, and a few more nits below, this LGTM.

https://codereview.chromium.org/17392006/diff/18018/components/autofill/core/...
File components/autofill/core/browser/DEPS (right):

https://codereview.chromium.org/17392006/diff/18018/components/autofill/core/...
components/autofill/core/browser/DEPS:51: # TODO(joi, kaiwang): Bring this list
to zero.
-kaiwang from the TODO

I think this had been done in another change recently in the file you moved this
from; something you may encounter when you try to land.

https://codereview.chromium.org/17392006/diff/18018/components/autofill/core/...
File components/autofill/core/browser/android/component_jni_registrar.h (right):

https://codereview.chromium.org/17392006/diff/18018/components/autofill/core/...
components/autofill/core/browser/android/component_jni_registrar.h:5: #ifndef
COMPONENT_AUTOFILL_BROWSER_ANDROID_COMPONENT_JNI_REGISTRAR_H_
Missing update to include guards in this file.

https://codereview.chromium.org/17392006/diff/18018/components/autofill/core/...
File components/autofill/core/browser/autofill-inl.h (right):

https://codereview.chromium.org/17392006/diff/18018/components/autofill/core/...
components/autofill/core/browser/autofill-inl.h:5: #ifndef
COMPONENTS_AUTOFILL_BROWSER_AUTOFILL_INL_H_
Missing update to include guard.

[blundell, 2013-06-18 22:40:10]

Unfortunately, every file is shown as having diff from the last patch for some
reason (if you go in and look at the side-by-side diff for the ones that don't
actually have any diff, you'll see that it doesn't show any).

I rebased to ToT locally without any conflicts.

Nico, if this looks good to you, please feel free to re-check commit.

Don't worry, I'm using mass-rename.py - I'm not crazy :).

https://codereview.chromium.org/17392006/diff/18018/chrome/browser/ui/android...
File chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc (right):

https://codereview.chromium.org/17392006/diff/18018/chrome/browser/ui/android...
chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc:11: #include
"chrome/browser/ui/android/autofill/autofill_dialog_view_android.h"
On 2013/06/18 21:52:29, Nico wrote:
> This ain't right. Keep it at the top, but add an empty line below it.

Done.

https://codereview.chromium.org/17392006/diff/18018/components/autofill/core/...
File components/autofill/core/browser/DEPS (right):

https://codereview.chromium.org/17392006/diff/18018/components/autofill/core/...
components/autofill/core/browser/DEPS:51: # TODO(joi, kaiwang): Bring this list
to zero.
On 2013/06/18 22:14:28, Jói wrote:
> -kaiwang from the TODO
> 
> I think this had been done in another change recently in the file you moved
this
> from; something you may encounter when you try to land.

Done.

https://codereview.chromium.org/17392006/diff/18018/components/autofill/core/...
File components/autofill/core/browser/android/component_jni_registrar.h (right):

https://codereview.chromium.org/17392006/diff/18018/components/autofill/core/...
components/autofill/core/browser/android/component_jni_registrar.h:5: #ifndef
COMPONENT_AUTOFILL_BROWSER_ANDROID_COMPONENT_JNI_REGISTRAR_H_
On 2013/06/18 22:14:28, Jói wrote:
> Missing update to include guards in this file.

Done.

https://codereview.chromium.org/17392006/diff/18018/components/autofill/core/...
File components/autofill/core/browser/autofill-inl.h (right):

https://codereview.chromium.org/17392006/diff/18018/components/autofill/core/...
components/autofill/core/browser/autofill-inl.h:5: #ifndef
COMPONENTS_AUTOFILL_BROWSER_AUTOFILL_INL_H_
On 2013/06/18 22:14:28, Jói wrote:
> Missing update to include guard.

Done.

[Nico, 2013-06-18 22:42:45]

lgtm

[commit-bot: I haz the power, 2013-06-18 22:42:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/17392006/45001

[Jói, 2013-06-18 22:44:43]

LGTM


On Tue, Jun 18, 2013 at 10:40 PM, <blundell@chromium.org> wrote:

> Unfortunately, every file is shown as having diff from the last patch for
> some
> reason (if you go in and look at the side-by-side diff for the ones that
> don't
> actually have any diff, you'll see that it doesn't show any).
>
> I rebased to ToT locally without any conflicts.
>
> Nico, if this looks good to you, please feel free to re-check commit.
>
> Don't worry, I'm using mass-rename.py - I'm not crazy :).
>
>
> https://codereview.chromium.**org/17392006/diff/18018/**
>
chrome/browser/ui/android/**autofill/autofill_dialog_view_**android.cc<https://codereview.chromium.org/17392006/diff/18018/chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc>
> File chrome/browser/ui/android/**autofill/autofill_dialog_view_**
> android.cc
> (right):
>
> https://codereview.chromium.**org/17392006/diff/18018/**
> chrome/browser/ui/android/**autofill/autofill_dialog_view_**
>
android.cc#newcode11<https://codereview.chromium.org/17392006/diff/18018/chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc#newcode11>
> chrome/browser/ui/android/**autofill/autofill_dialog_view_**android.cc:11:
> #include
> "chrome/browser/ui/android/**autofill/autofill_dialog_view_**android.h"
>
> On 2013/06/18 21:52:29, Nico wrote:
>
>> This ain't right. Keep it at the top, but add an empty line below it.
>>
>
> Done.
>
>
> https://codereview.chromium.**org/17392006/diff/18018/**
>
components/autofill/core/**browser/DEPS<https://codereview.chromium.org/17392006/diff/18018/components/autofill/core/browser/DEPS>
> File components/autofill/core/**browser/DEPS (right):
>
> https://codereview.chromium.**org/17392006/diff/18018/**
>
components/autofill/core/**browser/DEPS#newcode51<https://codereview.chromium.org/17392006/diff/18018/components/autofill/core/browser/DEPS#newcode51>
> components/autofill/core/**browser/DEPS:51: # TODO(joi, kaiwang): Bring
> this list to zero.
> On 2013/06/18 22:14:28, Jói wrote:
>
>> -kaiwang from the TODO
>>
>
>  I think this had been done in another change recently in the file you
>>
> moved this
>
>> from; something you may encounter when you try to land.
>>
>
> Done.
>
>
> https://codereview.chromium.**org/17392006/diff/18018/**
>
components/autofill/core/**browser/android/component_jni_**registrar.h<https://codereview.chromium.org/17392006/diff/18018/components/autofill/core/browser/android/component_jni_registrar.h>
> File components/autofill/core/**browser/android/component_jni_**
> registrar.h
> (right):
>
> https://codereview.chromium.**org/17392006/diff/18018/**
> components/autofill/core/**browser/android/component_jni_**
>
registrar.h#newcode5<https://codereview.chromium.org/17392006/diff/18018/components/autofill/core/browser/android/component_jni_registrar.h#newcode5>
> components/autofill/core/**browser/android/component_jni_**registrar.h:5:
> #ifndef COMPONENT_AUTOFILL_BROWSER_**ANDROID_COMPONENT_JNI_**REGISTRAR_H_
> On 2013/06/18 22:14:28, Jói wrote:
>
>> Missing update to include guards in this file.
>>
>
> Done.
>
>
> https://codereview.chromium.**org/17392006/diff/18018/**
>
components/autofill/core/**browser/autofill-inl.h<https://codereview.chromium.org/17392006/diff/18018/components/autofill/core/browser/autofill-inl.h>
> File components/autofill/core/**browser/autofill-inl.h (right):
>
> https://codereview.chromium.**org/17392006/diff/18018/**
>
components/autofill/core/**browser/autofill-inl.h#**newcode5<https://codereview.chromium.org/17392006/diff/18018/components/autofill/core/browser/autofill-inl.h#newcode5>
> components/autofill/core/**browser/autofill-inl.h:5: #ifndef
> COMPONENTS_AUTOFILL_BROWSER_**AUTOFILL_INL_H_
> On 2013/06/18 22:14:28, Jói wrote:
>
>> Missing update to include guard.
>>
>
> Done.
>
>
https://codereview.chromium.**org/17392006/<https://codereview.chromium.org/1...
>

[commit-bot: I haz the power, 2013-06-18 23:31:16]

Retried try job too often on win for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2013-06-19 05:10:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/17392006/45001

[commit-bot: I haz the power, 2013-06-19 05:11:12]

Failed to apply patch for components/autofill/core/browser/DEPS:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  A         components/autofill/core/browser
  Created missing directory components/autofill/core/browser.
  A         components/autofill/core/browser/DEPS
  Copied components/autofill/browser/DEPS ->
components/autofill/core/browser/DEPS
  patching file components/autofill/core/browser/DEPS
  Hunk #1 FAILED at 1.
  Hunk #2 succeeded at 23 (offset -8 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
components/autofill/core/browser/DEPS.rej

Patch:   NR 
components/autofill/browser/DEPS->components/autofill/core/browser/DEPS
Index: components/autofill/core/browser/DEPS
diff --git a/components/autofill/browser/DEPS
b/components/autofill/core/browser/DEPS
similarity index 63%
rename from components/autofill/browser/DEPS
rename to components/autofill/core/browser/DEPS
index
e59d894e96fab97f90a5f0edbc824f587cb798be..1c38eb4cda39c8313ac5067fbc9c7597a27ecda4
100644
--- a/components/autofill/browser/DEPS
+++ b/components/autofill/core/browser/DEPS
@@ -1,20 +1,37 @@
 include_rules = [
   "+components/webdata/common",
-  "+content/public/browser",
-  "+content/public/common",
   "+crypto/random.h",
   "+google_apis/gaia",
   "+google_apis/google_api_keys.h",
-  "+gpu/config/gpu_info.h",
   "+net",
   "+sql",
   "+third_party/libjingle",
   "+third_party/libphonenumber",  # For phone number i18n.
-  # Allow inclusion of WebKit API files.
-  "+third_party/WebKit/public/platform",
-  "+third_party/WebKit/Source/WebKit/chromium",
-  "+webkit/plugins/webplugininfo.h",
 
+  # TODO(blundell): Bring this list to zero.
+  #
+  # Do not add to the list of temporarily-allowed dependencies below,
+  # and please do not introduce more #includes of these files.
+  "!content/public/browser/android/content_view_core.h",
+  "!content/public/browser/browser_context.h",
+  "!content/public/browser/browser_thread.h",
+  "!content/public/browser/navigation_controller.h",
+  "!content/public/browser/navigation_details.h",
+  "!content/public/browser/notification_details.h",
+  "!content/public/browser/notification_observer.h",
+  "!content/public/browser/notification_registrar.h",
+  "!content/public/browser/notification_service.h",
+  "!content/public/browser/notification_source.h",
+  "!content/public/browser/notification_types.h",
+  "!content/public/browser/render_view_host.h",
+  "!content/public/browser/web_contents.h",
+  "!content/public/browser/web_contents_observer.h",
+  "!content/public/browser/web_contents_view.h",
+  "!content/public/common/frame_navigate_params.h",
+  "!content/public/common/url_constants.h",
+  "!third_party/WebKit/Source/WebKit/chromium/public/WebAutofillClient.h",
+  "!third_party/WebKit/Source/WebKit/chromium/public/WebInputElement.h",
+  
   # TODO(joi): This is "ok" temporarily (it's just a header file with
   # a large enum, and doesn't bring in any other dependencies on
   # //chrome). The plan of record to get rid of this is to change
@@ -31,7 +48,7 @@ specific_include_rules = {
   '.*_[a-z]*test\.cc': [
     "+content/public/test",
 
-    # TODO(joi, kaiwang): Bring this list to zero.
+    # TODO(joi): Bring this list to zero.
     #
     # Do not add to the list of temporarily-allowed dependencies below,
     # and please do not introduce more #includes of these files.

[commit-bot: I haz the power, 2013-06-19 06:25:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/17392006/38070

[commit-bot: I haz the power, 2013-06-19 11:40:26]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2013-06-19 11:44:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/17392006/38070

[commit-bot: I haz the power, 2013-06-20 11:44:40]

Change committed as 207403