Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: components/autofill/browser/autofill_external_delegate_unittest.cc

Issue 17392006: In components/autofill, move browser/ to core/browser/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase to fix conflicts Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/browser/autofill_external_delegate_unittest.cc
diff --git a/components/autofill/browser/autofill_external_delegate_unittest.cc b/components/autofill/browser/autofill_external_delegate_unittest.cc
deleted file mode 100644
index 96ae2b9270ccd9dec82db4da646a21d6e6ed1e88..0000000000000000000000000000000000000000
--- a/components/autofill/browser/autofill_external_delegate_unittest.cc
+++ /dev/null
@@ -1,365 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include <vector>
-
-#include "base/compiler_specific.h"
-#include "base/strings/string16.h"
-#include "base/strings/utf_string_conversions.h"
-#include "chrome/test/base/chrome_render_view_host_test_harness.h"
-#include "chrome/test/base/testing_profile.h"
-#include "components/autofill/browser/autofill_manager.h"
-#include "components/autofill/browser/test_autofill_driver.h"
-#include "components/autofill/browser/test_autofill_external_delegate.h"
-#include "components/autofill/browser/test_autofill_manager_delegate.h"
-#include "components/autofill/core/common/form_data.h"
-#include "components/autofill/core/common/form_field_data.h"
-#include "components/autofill/core/common/password_form_fill_data.h"
-#include "testing/gmock/include/gmock/gmock.h"
-#include "testing/gtest/include/gtest/gtest.h"
-#include "third_party/WebKit/Source/WebKit/chromium/public/WebAutofillClient.h"
-#include "ui/gfx/rect.h"
-
-using testing::_;
-using WebKit::WebAutofillClient;
-
-namespace autofill {
-
-namespace {
-
-// A constant value to use as the Autofill query ID.
-const int kQueryId = 5;
-
-// A constant value to use as an Autofill profile ID.
-const int kAutofillProfileId = 1;
-
-class MockAutofillExternalDelegate : public AutofillExternalDelegate {
- public:
- MockAutofillExternalDelegate(content::WebContents* web_contents,
- AutofillManager* autofill_manger)
- : AutofillExternalDelegate(web_contents, autofill_manger) {}
-
- ~MockAutofillExternalDelegate() {}
-
- MOCK_METHOD0(ClearPreviewedForm, void());
-
- private:
- DISALLOW_COPY_AND_ASSIGN(MockAutofillExternalDelegate);
-};
-
-class MockAutofillManagerDelegate
- : public autofill::TestAutofillManagerDelegate {
- public:
- MockAutofillManagerDelegate() {}
-
- MOCK_METHOD7(ShowAutofillPopup,
- void(const gfx::RectF& element_bounds,
- base::i18n::TextDirection text_direction,
- const std::vector<base::string16>& values,
- const std::vector<base::string16>& labels,
- const std::vector<base::string16>& icons,
- const std::vector<int>& identifiers,
- base::WeakPtr<AutofillPopupDelegate> delegate));
-
- MOCK_METHOD0(HideAutofillPopup, void());
-
- private:
- DISALLOW_COPY_AND_ASSIGN(MockAutofillManagerDelegate);
-};
-
-class MockAutofillManager : public AutofillManager {
- public:
- MockAutofillManager(AutofillDriver* driver,
- MockAutofillManagerDelegate* delegate)
- // Force to use the constructor designated for unit test, but we don't
- // really need personal_data in this test so we pass a NULL pointer.
- : AutofillManager(driver, delegate, NULL) {
- }
- virtual ~MockAutofillManager() {}
-
- MOCK_METHOD4(OnFillAutofillFormData,
- void(int query_id,
- const FormData& form,
- const FormFieldData& field,
- int unique_id));
-
- private:
- DISALLOW_COPY_AND_ASSIGN(MockAutofillManager);
-};
-
-} // namespace
-
-class AutofillExternalDelegateUnitTest
- : public ChromeRenderViewHostTestHarness {
- protected:
- virtual void SetUp() OVERRIDE {
- ChromeRenderViewHostTestHarness::SetUp();
- autofill_driver_.reset(new TestAutofillDriver(web_contents()));
- autofill_manager_.reset(
- new MockAutofillManager(autofill_driver_.get(),
- &manager_delegate_));
- external_delegate_.reset(
- new testing::NiceMock<MockAutofillExternalDelegate>(
- web_contents(),
- autofill_manager_.get()));
- }
-
- virtual void TearDown() OVERRIDE {
- // Order of destruction is important as AutofillManager relies on
- // PersonalDataManager to be around when it gets destroyed. Also, a real
- // AutofillManager is tied to the lifetime of the WebContents, so it must
- // be destroyed at the destruction of the WebContents.
- autofill_manager_.reset();
- external_delegate_.reset();
- autofill_driver_.reset();
- ChromeRenderViewHostTestHarness::TearDown();
- }
-
- // Issue an OnQuery call with the given |query_id|.
- void IssueOnQuery(int query_id) {
- const FormData form;
- FormFieldData field;
- field.is_focusable = true;
- field.should_autocomplete = true;
- const gfx::RectF element_bounds;
-
- external_delegate_->OnQuery(query_id, form, field, element_bounds, true);
- }
-
- MockAutofillManagerDelegate manager_delegate_;
- scoped_ptr<AutofillDriver> autofill_driver_;
- scoped_ptr<MockAutofillManager> autofill_manager_;
- scoped_ptr<testing::NiceMock<MockAutofillExternalDelegate> >
- external_delegate_;
-};
-
-// Test that our external delegate called the virtual methods at the right time.
-TEST_F(AutofillExternalDelegateUnitTest, TestExternalDelegateVirtualCalls) {
- IssueOnQuery(kQueryId);
-
- // The enums must be cast to ints to prevent compile errors on linux_rel.
- EXPECT_CALL(manager_delegate_,
- ShowAutofillPopup(
- _, _, _, _, _,
- testing::ElementsAre(
- kAutofillProfileId,
- static_cast<int>(WebAutofillClient::MenuItemIDSeparator),
- static_cast<int>(
- WebAutofillClient::MenuItemIDAutofillOptions)),
- _));
-
- // This should call ShowAutofillPopup.
- std::vector<base::string16> autofill_item;
- autofill_item.push_back(base::string16());
- std::vector<int> autofill_ids;
- autofill_ids.push_back(kAutofillProfileId);
- external_delegate_->OnSuggestionsReturned(kQueryId,
- autofill_item,
- autofill_item,
- autofill_item,
- autofill_ids);
-
- // Called by DidAutofillSuggestions, add expectation to remove warning.
- EXPECT_CALL(*autofill_manager_, OnFillAutofillFormData(_, _, _, _));
-
- EXPECT_CALL(manager_delegate_, HideAutofillPopup());
-
- // This should trigger a call to hide the popup since we've selected an
- // option.
- external_delegate_->DidAcceptSuggestion(autofill_item[0], autofill_ids[0]);
-}
-
-// Test that data list elements for a node will appear in the Autofill popup.
-TEST_F(AutofillExternalDelegateUnitTest, ExternalDelegateDataList) {
- IssueOnQuery(kQueryId);
-
- std::vector<base::string16> data_list_items;
- data_list_items.push_back(base::string16());
- std::vector<int> data_list_ids;
- data_list_ids.push_back(WebAutofillClient::MenuItemIDDataListEntry);
-
- external_delegate_->SetCurrentDataListValues(data_list_items,
- data_list_items,
- data_list_items,
- data_list_ids);
-
- // The enums must be cast to ints to prevent compile errors on linux_rel.
- EXPECT_CALL(manager_delegate_,
- ShowAutofillPopup(
- _, _, _, _, _,
- testing::ElementsAre(
- static_cast<int>(
- WebAutofillClient::MenuItemIDDataListEntry),
- static_cast<int>(WebAutofillClient::MenuItemIDSeparator),
- kAutofillProfileId,
- static_cast<int>(WebAutofillClient::MenuItemIDSeparator),
- static_cast<int>(
- WebAutofillClient::MenuItemIDAutofillOptions)),
- _));
-
- // This should call ShowAutofillPopup.
- std::vector<base::string16> autofill_item;
- autofill_item.push_back(base::string16());
- std::vector<int> autofill_ids;
- autofill_ids.push_back(kAutofillProfileId);
- external_delegate_->OnSuggestionsReturned(kQueryId,
- autofill_item,
- autofill_item,
- autofill_item,
- autofill_ids);
-
- // Try calling OnSuggestionsReturned with no Autofill values and ensure
- // the datalist items are still shown.
- // The enum must be cast to an int to prevent compile errors on linux_rel.
- EXPECT_CALL(manager_delegate_,
- ShowAutofillPopup(
- _, _, _, _, _,
- testing::ElementsAre(
- static_cast<int>(
- WebAutofillClient::MenuItemIDDataListEntry)),
- _));
-
- autofill_item = std::vector<base::string16>();
- autofill_ids = std::vector<int>();
- external_delegate_->OnSuggestionsReturned(kQueryId,
- autofill_item,
- autofill_item,
- autofill_item,
- autofill_ids);
-}
-
-// Test that the Autofill popup is able to display warnings explaining why
-// Autofill is disabled for a website.
-// Regression test for http://crbug.com/247880
-TEST_F(AutofillExternalDelegateUnitTest, AutofillWarnings) {
- IssueOnQuery(kQueryId);
-
- // The enums must be cast to ints to prevent compile errors on linux_rel.
- EXPECT_CALL(manager_delegate_,
- ShowAutofillPopup(
- _, _, _, _, _,
- testing::ElementsAre(
- static_cast<int>(
- WebAutofillClient::MenuItemIDWarningMessage)),
- _));
-
- // This should call ShowAutofillPopup.
- std::vector<base::string16> autofill_item;
- autofill_item.push_back(base::string16());
- std::vector<int> autofill_ids;
- autofill_ids.push_back(WebAutofillClient::MenuItemIDWarningMessage);
- external_delegate_->OnSuggestionsReturned(kQueryId,
- autofill_item,
- autofill_item,
- autofill_item,
- autofill_ids);
-}
-
-// Test that the Autofill delegate doesn't try and fill a form with a
-// negative unique id.
-TEST_F(AutofillExternalDelegateUnitTest, ExternalDelegateInvalidUniqueId) {
- // Ensure it doesn't try to preview the negative id.
- EXPECT_CALL(*autofill_manager_, OnFillAutofillFormData(_, _, _, _)).Times(0);
- EXPECT_CALL(*external_delegate_, ClearPreviewedForm()).Times(1);
- external_delegate_->DidSelectSuggestion(-1);
-
- // Ensure it doesn't try to fill the form in with the negative id.
- EXPECT_CALL(manager_delegate_, HideAutofillPopup());
- EXPECT_CALL(*autofill_manager_, OnFillAutofillFormData(_, _, _, _)).Times(0);
- external_delegate_->DidAcceptSuggestion(base::string16(), -1);
-}
-
-// Test that the ClearPreview IPC is only sent the form was being previewed
-// (i.e. it isn't autofilling a password).
-TEST_F(AutofillExternalDelegateUnitTest, ExternalDelegateClearPreviewedForm) {
- // Called by DidSelectSuggestion, add expectation to remove warning.
- EXPECT_CALL(*autofill_manager_, OnFillAutofillFormData(_, _, _, _));
-
- // Ensure selecting a new password entries or Autofill entries will
- // cause any previews to get cleared.
- EXPECT_CALL(*external_delegate_, ClearPreviewedForm()).Times(1);
- external_delegate_->DidSelectSuggestion(
- WebAutofillClient::MenuItemIDPasswordEntry);
-
- EXPECT_CALL(*external_delegate_, ClearPreviewedForm()).Times(1);
- external_delegate_->DidSelectSuggestion(1);
-}
-
-// Test that the popup is hidden once we are done editing the autofill field.
-TEST_F(AutofillExternalDelegateUnitTest,
- ExternalDelegateHidePopupAfterEditing) {
- EXPECT_CALL(manager_delegate_, ShowAutofillPopup(_, _, _, _, _, _, _));
- autofill::GenerateTestAutofillPopup(external_delegate_.get());
-
- EXPECT_CALL(manager_delegate_, HideAutofillPopup());
- external_delegate_->DidEndTextFieldEditing();
-}
-
-// Test that the popup is marked as visible after recieving password
-// suggestions.
-TEST_F(AutofillExternalDelegateUnitTest, ExternalDelegatePasswordSuggestions) {
- static const base::string16 kUsername = ASCIIToUTF16("username");
- std::vector<base::string16> suggestions;
- suggestions.push_back(kUsername);
-
- FormFieldData field;
- field.is_focusable = true;
- field.should_autocomplete = true;
- const gfx::RectF element_bounds;
-
- FormFieldData username_field_data;
- username_field_data.value = kUsername;
- PasswordFormFillData password_form_fill_data;
- password_form_fill_data.basic_data.fields.push_back(username_field_data);
- external_delegate_->AddPasswordFormMapping(field, password_form_fill_data);
-
- // The enums must be cast to ints to prevent compile errors on linux_rel.
- EXPECT_CALL(manager_delegate_,
- ShowAutofillPopup(
- _, _, _, _, _,
- testing::ElementsAre(
- static_cast<int>(
- WebAutofillClient::MenuItemIDPasswordEntry)),
- _));
-
- external_delegate_->OnShowPasswordSuggestions(suggestions,
- field,
- element_bounds);
-
- EXPECT_CALL(manager_delegate_, HideAutofillPopup());
-
- // This should trigger a call to hide the popup since
- // we've selected an option.
- external_delegate_->DidAcceptSuggestion(
- suggestions[0],
- WebAutofillClient::MenuItemIDPasswordEntry);
-}
-
-TEST_F(AutofillExternalDelegateUnitTest, ExternalDelegateHideWarning) {
- // Set up a field that shouldn't get autocompleted or display warnings.
- const FormData form;
- FormFieldData field;
- field.is_focusable = true;
- field.should_autocomplete = false;
- const gfx::RectF element_bounds;
-
- external_delegate_->OnQuery(kQueryId, form, field, element_bounds, false);
-
- std::vector<base::string16> autofill_items;
- autofill_items.push_back(base::string16());
- std::vector<int> autofill_ids;
- autofill_ids.push_back(WebAutofillClient::MenuItemIDAutocompleteEntry);
-
- // Ensure the popup tries to hide itself, since it is not allowed to show
- // anything.
- EXPECT_CALL(manager_delegate_, HideAutofillPopup());
-
- external_delegate_->OnSuggestionsReturned(kQueryId,
- autofill_items,
- autofill_items,
- autofill_items,
- autofill_ids);
-}
-
-} // namespace autofill
« no previous file with comments | « components/autofill/browser/autofill_external_delegate.cc ('k') | components/autofill/browser/autofill_field.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698