cc: Remove FakeThread, use SingleThreadTaskRunner in scheduling classes.

cc: Remove FakeThread, use SingleThreadTaskRunner in scheduling classes.

This changes from using cc::Thread to base::SingleThreadTaskRunner in
FrameRateController, DelayBasedTimeSource, and ResourceUpdateController.
Then all unit tests for these classes are switched from using
cc::FakeThread to base::TestSimpleTaskRunner.

This is a step toward deleting cc::Thread and moving to using
MessageLoopProxy directly in cc.

R=piman
BUG=251134
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207027

[danakj, 2013-06-18 02:58:54]

+akalin fyi for base/

[piman, 2013-06-18 03:02:45]

LGTM, 1q

https://codereview.chromium.org/17362002/diff/2001/cc/resources/resource_upda...
File cc/resources/resource_update_controller_unittest.cc (right):

https://codereview.chromium.org/17362002/diff/2001/cc/resources/resource_upda...
cc/resources/resource_update_controller_unittest.cc:185: NULL,
OK to pass a NULL TaskRunner here?

[danakj, 2013-06-18 03:03:34]

https://codereview.chromium.org/17362002/diff/2001/cc/resources/resource_upda...
File cc/resources/resource_update_controller_unittest.cc (right):

https://codereview.chromium.org/17362002/diff/2001/cc/resources/resource_upda...
cc/resources/resource_update_controller_unittest.cc:185: NULL,
On 2013/06/18 03:02:45, piman wrote:
> OK to pass a NULL TaskRunner here?

It's not used and equivalent to the old code. The ImplThread() given to the
proxy up above is NULL, so the RUC was getting a NULL here before also.

[danakj, 2013-06-18 03:04:00]

+brettw for base/ OWNERS

[brettw, 2013-06-18 05:27:09]

base owners lgtm rubberstamp

[commit-bot: I haz the power, 2013-06-18 15:21:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/17362002/11001

[commit-bot: I haz the power, 2013-06-18 15:21:26]

Failed to apply patch for cc/scheduler/frame_rate_controller.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file cc/scheduler/frame_rate_controller.cc
  Hunk #2 FAILED at 40.
  Hunk #3 FAILED at 93.
  Hunk #4 succeeded at 108 (offset 4 lines).
  2 out of 4 hunks FAILED -- saving rejects to file
cc/scheduler/frame_rate_controller.cc.rej

Patch:       cc/scheduler/frame_rate_controller.cc
Index: cc/scheduler/frame_rate_controller.cc
diff --git a/cc/scheduler/frame_rate_controller.cc
b/cc/scheduler/frame_rate_controller.cc
index
b4f1272e2d2c52513365371e2fa7d757e194c3d3..5db6498823cdc92f3b99a8bad3954b32bc29fc31
100644
--- a/cc/scheduler/frame_rate_controller.cc
+++ b/cc/scheduler/frame_rate_controller.cc
@@ -5,8 +5,9 @@
 #include "cc/scheduler/frame_rate_controller.h"
 
 #include "base/debug/trace_event.h"
+#include "base/location.h"
 #include "base/logging.h"
-#include "cc/base/thread.h"
+#include "base/single_thread_task_runner.h"
 #include "cc/scheduler/delay_based_time_source.h"
 #include "cc/scheduler/time_source.h"
 
@@ -39,20 +40,21 @@
FrameRateController::FrameRateController(scoped_refptr<TimeSource> timer)
       active_(false),
       is_time_source_throttling_(true),
       weak_factory_(this),
-      thread_(NULL) {
+      task_runner_(NULL) {
   time_source_client_adapter_ =
       FrameRateControllerTimeSourceAdapter::Create(this);
   time_source_->SetClient(time_source_client_adapter_.get());
 }
 
-FrameRateController::FrameRateController(Thread* thread)
+FrameRateController::FrameRateController(
+    base::SingleThreadTaskRunner* task_runner)
     : client_(NULL),
       num_frames_pending_(0),
       max_frames_pending_(0),
       active_(false),
       is_time_source_throttling_(false),
       weak_factory_(this),
-      thread_(thread) {}
+      task_runner_(task_runner) {}
 
 FrameRateController::~FrameRateController() {
   if (is_time_source_throttling_)
@@ -92,7 +94,7 @@ void FrameRateController::OnTimerTick() {
   // Check if we have too many frames in flight.
   bool throttled =
       max_frames_pending_ && num_frames_pending_ >= max_frames_pending_;
-  TRACE_COUNTER_ID1("cc", "ThrottledCompositor", thread_, throttled);
+  TRACE_COUNTER_ID1("cc", "ThrottledCompositor", task_runner_, throttled);
 
   if (client_)
     client_->BeginFrame(throttled);
@@ -103,8 +105,9 @@ void FrameRateController::OnTimerTick() {
 
 void FrameRateController::PostManualTick() {
   if (active_) {
-    thread_->PostTask(base::Bind(&FrameRateController::ManualTick,
-                                 weak_factory_.GetWeakPtr()));
+    task_runner_->PostTask(FROM_HERE,
+                           base::Bind(&FrameRateController::ManualTick,
+                                      weak_factory_.GetWeakPtr()));
   }
 }

[commit-bot: I haz the power, 2013-06-18 15:35:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/17362002/18001

[commit-bot: I haz the power, 2013-06-18 17:39:53]

Change committed as 207027