Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 17227003: Change google_apis::DriveUploader interface to return CancelCallback. (Closed)

Created:
7 years, 6 months ago by kinaba
Modified:
7 years, 6 months ago
Reviewers:
hashimoto, tzik
CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, oshima+watch_chromium.org, tzik+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Change google_apis::DriveUploader interface to return CancelCallback. It only changes the interface and just returns null for now. The implementation will come soon. BUG=250712 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206701

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -56 lines) Patch
M chrome/browser/chromeos/drive/job_scheduler.cc View 3 chunks +20 lines, -26 lines 0 comments Download
M chrome/browser/google_apis/drive_uploader.h View 8 chunks +19 lines, -18 lines 0 comments Download
M chrome/browser/google_apis/drive_uploader.cc View 4 chunks +16 lines, -9 lines 0 comments Download
M chrome/browser/sync_file_system/drive/api_util_unittest.cc View 4 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kinaba
Splitting up the patch to a simpler part.
7 years, 6 months ago (2013-06-17 07:01:47 UTC) #1
hashimoto
lgtm
7 years, 6 months ago (2013-06-17 07:04:29 UTC) #2
tzik
lgtm
7 years, 6 months ago (2013-06-17 07:50:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/17227003/1
7 years, 6 months ago (2013-06-17 07:52:57 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-17 11:01:17 UTC) #5
Message was sent while issue was closed.
Change committed as 206701

Powered by Google App Engine
This is Rietveld 408576698