Issue 17227003: Change google_apis::DriveUploader interface to return CancelCallback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17227003: Change google_apis::DriveUploader interface to return CancelCallback. (Closed)

Created:
7 years, 6 months ago by kinaba

Modified:
7 years, 6 months ago

Reviewers:
hashimoto, tzik

CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, oshima+watch_chromium.org, tzik+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Change google_apis::DriveUploader interface to return CancelCallback. It only changes the interface and just returns null for now. The implementation will come soon. BUG=250712 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206701

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -56 lines)			Patch
M	chrome/browser/chromeos/drive/job_scheduler.cc	View	3 chunks	+20 lines, -26 lines	0 comments	Download
M	chrome/browser/google_apis/drive_uploader.h	View	8 chunks	+19 lines, -18 lines	0 comments	Download
M	chrome/browser/google_apis/drive_uploader.cc	View	4 chunks	+16 lines, -9 lines	0 comments	Download
M	chrome/browser/sync_file_system/drive/api_util_unittest.cc	View	4 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/17227003/1

7 years, 6 months ago (2013-06-17 07:52:57 UTC) #4

Message was sent while issue was closed.

Change committed as 206701

Expand Messages | Collapse Messages