Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Unified Diff: chrome/browser/chromeos/drive/job_scheduler.cc

Issue 17227003: Change google_apis::DriveUploader interface to return CancelCallback. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/google_apis/drive_uploader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/drive/job_scheduler.cc
diff --git a/chrome/browser/chromeos/drive/job_scheduler.cc b/chrome/browser/chromeos/drive/job_scheduler.cc
index db3ceb9862ebce06f9385cdff67ca706ea249705..b5d123de6490be3eaa429747d53a5f92b071a72c 100644
--- a/chrome/browser/chromeos/drive/job_scheduler.cc
+++ b/chrome/browser/chromeos/drive/job_scheduler.cc
@@ -42,15 +42,13 @@ struct UploadNewFileParams {
google_apis::CancelCallback RunUploadNewFile(
google_apis::DriveUploaderInterface* uploader,
const UploadNewFileParams& params) {
- uploader->UploadNewFile(params.parent_resource_id,
- params.drive_file_path,
- params.local_file_path,
- params.title,
- params.content_type,
- params.callback,
- params.progress_callback);
- // TODO(kinaba): crbug.com/231209 Return a proper CancelCallback.
- return google_apis::CancelCallback();
+ return uploader->UploadNewFile(params.parent_resource_id,
+ params.drive_file_path,
+ params.local_file_path,
+ params.title,
+ params.content_type,
+ params.callback,
+ params.progress_callback);
}
// Parameter struct for RunUploadExistingFile.
@@ -68,15 +66,13 @@ struct UploadExistingFileParams {
google_apis::CancelCallback RunUploadExistingFile(
google_apis::DriveUploaderInterface* uploader,
const UploadExistingFileParams& params) {
- uploader->UploadExistingFile(params.resource_id,
- params.drive_file_path,
- params.local_file_path,
- params.content_type,
- params.etag,
- params.callback,
- params.progress_callback);
- // TODO(kinaba): crbug.com/231209 Return a proper CancelCallback.
- return google_apis::CancelCallback();
+ return uploader->UploadExistingFile(params.resource_id,
+ params.drive_file_path,
+ params.local_file_path,
+ params.content_type,
+ params.etag,
+ params.callback,
+ params.progress_callback);
}
// Parameter struct for RunResumeUploadFile.
@@ -93,14 +89,12 @@ struct ResumeUploadFileParams {
google_apis::CancelCallback RunResumeUploadFile(
google_apis::DriveUploaderInterface* uploader,
const ResumeUploadFileParams& params) {
- uploader->ResumeUploadFile(params.upload_location,
- params.drive_file_path,
- params.local_file_path,
- params.content_type,
- params.callback,
- params.progress_callback);
- // TODO(kinaba): crbug.com/231209 Return a proper CancelCallback.
- return google_apis::CancelCallback();
+ return uploader->ResumeUploadFile(params.upload_location,
+ params.drive_file_path,
+ params.local_file_path,
+ params.content_type,
+ params.callback,
+ params.progress_callback);
}
} // namespace
« no previous file with comments | « no previous file | chrome/browser/google_apis/drive_uploader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698