Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1112)

Issue 1716673002: Web Animations: Throw exceptions for play/pause/reverse/finish with infinite end time (Closed)

Created:
4 years, 10 months ago by dstockwell
Modified:
4 years, 10 months ago
Reviewers:
shans
CC:
shans, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web Animations: Throw exceptions for play/pause/reverse/finish with infinite end time https://w3c.github.io/web-animations/#pause-an-animation https://w3c.github.io/web-animations/#finish-an-animation https://w3c.github.io/web-animations/#reverse-an-animation https://w3c.github.io/web-animations/#play-an-animation Added test also passes in Firefox nightly. Committed: https://crrev.com/11efbc5592132de8ad0f2e5ef158ecaf91cb8861 Cr-Commit-Position: refs/heads/master@{#376951}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -14 lines) Patch
A third_party/WebKit/LayoutTests/web-animations-api/infinite-end-time.html View 1 chunk +54 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/Animation.h View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/Animation.cpp View 1 2 5 chunks +14 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/animation/Animation.idl View 1 2 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
dstockwell
4 years, 10 months ago (2016-02-19 02:37:40 UTC) #4
shans
lgtm
4 years, 10 months ago (2016-02-21 23:41:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716673002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716673002/40001
4 years, 10 months ago (2016-02-22 05:19:18 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/134010) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 10 months ago (2016-02-22 05:22:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716673002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716673002/40001
4 years, 10 months ago (2016-02-23 04:51:08 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/177848)
4 years, 10 months ago (2016-02-23 07:29:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716673002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716673002/40001
4 years, 10 months ago (2016-02-23 07:38:04 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-23 08:37:33 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 08:38:52 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/11efbc5592132de8ad0f2e5ef158ecaf91cb8861
Cr-Commit-Position: refs/heads/master@{#376951}

Powered by Google App Engine
This is Rietveld 408576698