Issue 17095007: Clean up keyboard overlay code for shortcut keys with Search modifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17095007: Clean up keyboard overlay code for shortcut keys with Search modifier. (Closed)

Created:
7 years, 6 months ago by mazda

Modified:
7 years, 6 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Clean up keyboard overlay code for shortcut keys with Search modifier. I added the shortcut with Search modifier to the master spreadsheet and enabled the data can be generated by gen_keyboard_overlay_data.py. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207737

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+86 lines, -103 lines)			Patch
M	chrome/app/chromeos_strings.grdp	View	6 chunks	+45 lines, -45 lines	0 comments	Download
M	chrome/browser/resources/chromeos/keyboard_overlay.js	View	1 chunk	+0 lines, -45 lines	0 comments	Download
M	chrome/browser/resources/chromeos/keyboard_overlay_data.js	View	7 chunks	+28 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc	View	3 chunks	+13 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/17095007/1

7 years, 6 months ago (2013-06-20 22:50:32 UTC) #3

Message was sent while issue was closed.

Change committed as 207737

Expand Messages | Collapse Messages