Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1644)

Unified Diff: chrome/browser/resources/chromeos/keyboard_overlay.js

Issue 17095007: Clean up keyboard overlay code for shortcut keys with Search modifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/chromeos_strings.grdp ('k') | chrome/browser/resources/chromeos/keyboard_overlay_data.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/keyboard_overlay.js
diff --git a/chrome/browser/resources/chromeos/keyboard_overlay.js b/chrome/browser/resources/chromeos/keyboard_overlay.js
index 3c19cecb8d10bc70949ec8ade99321d8ae7ca345..d28515f7c3a99eddfa4e86122fac7c2b44295ecf 100644
--- a/chrome/browser/resources/chromeos/keyboard_overlay.js
+++ b/chrome/browser/resources/chromeos/keyboard_overlay.js
@@ -141,51 +141,6 @@ function getShortcutData() {
delete shortcutDataCache['0<>CTRL<>SHIFT'];
}
- // TODO(mazda): Clean this up and move these out to the data js.
- var searchModifierAddShortcuts = {
- '1<>SEARCH': 'keyboardOverlayF1',
- '2<>SEARCH': 'keyboardOverlayF2',
- '3<>SEARCH': 'keyboardOverlayF3',
- '4<>SEARCH': 'keyboardOverlayF4',
- '5<>SEARCH': 'keyboardOverlayF5',
- '6<>SEARCH': 'keyboardOverlayF6',
- '7<>SEARCH': 'keyboardOverlayF7',
- '8<>SEARCH': 'keyboardOverlayF8',
- '9<>SEARCH': 'keyboardOverlayF9',
- '0<>SEARCH': 'keyboardOverlayF10',
- '-<>SEARCH': 'keyboardOverlayF11',
- '=<>SEARCH': 'keyboardOverlayF12',
- 'F1<>SEARCH': 'keyboardOverlayF1',
- 'F2<>SEARCH': 'keyboardOverlayF2',
- 'F3<>SEARCH': 'keyboardOverlayF3',
- 'F4<>SEARCH': 'keyboardOverlayF4',
- 'F5<>SEARCH': 'keyboardOverlayF5',
- 'F6<>SEARCH': 'keyboardOverlayF6',
- 'F7<>SEARCH': 'keyboardOverlayF7',
- 'F8<>SEARCH': 'keyboardOverlayF8',
- 'F9<>SEARCH': 'keyboardOverlayF9',
- 'F10<>SEARCH': 'keyboardOverlayF10',
- 'F11<>SEARCH': 'keyboardOverlayF11',
- 'F12<>SEARCH': 'keyboardOverlayF12',
- 'back<>SEARCH': 'keyboardOverlayF1',
- 'forward<>SEARCH': 'keyboardOverlayF2',
- 'reload<>SEARCH': 'keyboardOverlayF3',
- 'full screen<>SEARCH': 'keyboardOverlayF4',
- 'switch window<>SEARCH': 'keyboardOverlayF5',
- 'bright down<>SEARCH': 'keyboardOverlayF6',
- 'bright up<>SEARCH': 'keyboardOverlayF7',
- 'mute<>SEARCH': 'keyboardOverlayF8',
- 'vol. down<>SEARCH': 'keyboardOverlayF9',
- 'vol. up<>SEARCH': 'keyboardOverlayF10',
- 'backspace<>SEARCH': 'keyboardOverlayDelete',
- 'down<>SEARCH': 'keyboardOverlayPageDown',
- 'right<>SEARCH': 'keyboardOverlayEnd',
- 'up<>SEARCH': 'keyboardOverlayPageUp',
- 'left<>SEARCH': 'keyboardOverlayHome',
- '.<>SEARCH': 'keyboardOverlayInsert'
- };
- for (var key in searchModifierAddShortcuts)
- shortcutDataCache[key] = searchModifierAddShortcuts[key];
return shortcutDataCache;
}
« no previous file with comments | « chrome/app/chromeos_strings.grdp ('k') | chrome/browser/resources/chromeos/keyboard_overlay_data.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698