Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1358)

Side by Side Diff: chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc

Issue 17095007: Clean up keyboard overlay code for shortcut keys with Search modifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/chromeos/keyboard_overlay_data.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.h" 5 #include "chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.h"
6 6
7 #include "ash/display/display_manager.h" 7 #include "ash/display/display_manager.h"
8 #include "ash/shell.h" 8 #include "ash/shell.h"
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 {chromeos::input_method::kVoidKey, "disabled"}, 55 {chromeos::input_method::kVoidKey, "disabled"},
56 {chromeos::input_method::kCapsLockKey, "caps lock"}, 56 {chromeos::input_method::kCapsLockKey, "caps lock"},
57 }; 57 };
58 58
59 struct I18nContentToMessage { 59 struct I18nContentToMessage {
60 const char* i18n_content; 60 const char* i18n_content;
61 int message; 61 int message;
62 } kI18nContentToMessage[] = { 62 } kI18nContentToMessage[] = {
63 { "keyboardOverlayLearnMore", IDS_KEYBOARD_OVERLAY_LEARN_MORE }, 63 { "keyboardOverlayLearnMore", IDS_KEYBOARD_OVERLAY_LEARN_MORE },
64 { "keyboardOverlayTitle", IDS_KEYBOARD_OVERLAY_TITLE }, 64 { "keyboardOverlayTitle", IDS_KEYBOARD_OVERLAY_TITLE },
65 { "keyboardOverlayF1", IDS_KEYBOARD_OVERLAY_F1 },
66 { "keyboardOverlayF2", IDS_KEYBOARD_OVERLAY_F2 },
67 { "keyboardOverlayF3", IDS_KEYBOARD_OVERLAY_F3 },
68 { "keyboardOverlayF4", IDS_KEYBOARD_OVERLAY_F4 },
69 { "keyboardOverlayF5", IDS_KEYBOARD_OVERLAY_F5 },
70 { "keyboardOverlayF6", IDS_KEYBOARD_OVERLAY_F6 },
71 { "keyboardOverlayF7", IDS_KEYBOARD_OVERLAY_F7 },
72 { "keyboardOverlayF8", IDS_KEYBOARD_OVERLAY_F8 },
73 { "keyboardOverlayF9", IDS_KEYBOARD_OVERLAY_F9 },
74 { "keyboardOverlayF10", IDS_KEYBOARD_OVERLAY_F10 },
75 { "keyboardOverlayF11", IDS_KEYBOARD_OVERLAY_F11 },
76 { "keyboardOverlayF12", IDS_KEYBOARD_OVERLAY_F12 },
77 { "keyboardOverlayInsert", IDS_KEYBOARD_OVERLAY_INSERT },
78 { "keyboardOverlayInstructions", IDS_KEYBOARD_OVERLAY_INSTRUCTIONS }, 65 { "keyboardOverlayInstructions", IDS_KEYBOARD_OVERLAY_INSTRUCTIONS },
79 { "keyboardOverlayInstructionsHide", IDS_KEYBOARD_OVERLAY_INSTRUCTIONS_HIDE }, 66 { "keyboardOverlayInstructionsHide", IDS_KEYBOARD_OVERLAY_INSTRUCTIONS_HIDE },
80 { "keyboardOverlayActivateLastLauncherItem", 67 { "keyboardOverlayActivateLastLauncherItem",
81 IDS_KEYBOARD_OVERLAY_ACTIVATE_LAST_LAUNCHER_ITEM }, 68 IDS_KEYBOARD_OVERLAY_ACTIVATE_LAST_LAUNCHER_ITEM },
82 { "keyboardOverlayActivateLastTab", IDS_KEYBOARD_OVERLAY_ACTIVATE_LAST_TAB }, 69 { "keyboardOverlayActivateLastTab", IDS_KEYBOARD_OVERLAY_ACTIVATE_LAST_TAB },
83 { "keyboardOverlayActivateLauncherItem1", 70 { "keyboardOverlayActivateLauncherItem1",
84 IDS_KEYBOARD_OVERLAY_ACTIVATE_LAUNCHER_ITEM_1 }, 71 IDS_KEYBOARD_OVERLAY_ACTIVATE_LAUNCHER_ITEM_1 },
85 { "keyboardOverlayActivateLauncherItem2", 72 { "keyboardOverlayActivateLauncherItem2",
86 IDS_KEYBOARD_OVERLAY_ACTIVATE_LAUNCHER_ITEM_2 }, 73 IDS_KEYBOARD_OVERLAY_ACTIVATE_LAUNCHER_ITEM_2 },
87 { "keyboardOverlayActivateLauncherItem3", 74 { "keyboardOverlayActivateLauncherItem3",
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 { "keyboardOverlayDecreaseKeyBrightness", 112 { "keyboardOverlayDecreaseKeyBrightness",
126 IDS_KEYBOARD_OVERLAY_DECREASE_KEY_BRIGHTNESS }, 113 IDS_KEYBOARD_OVERLAY_DECREASE_KEY_BRIGHTNESS },
127 { "keyboardOverlayDelete", IDS_KEYBOARD_OVERLAY_DELETE }, 114 { "keyboardOverlayDelete", IDS_KEYBOARD_OVERLAY_DELETE },
128 { "keyboardOverlayDeleteWord", IDS_KEYBOARD_OVERLAY_DELETE_WORD }, 115 { "keyboardOverlayDeleteWord", IDS_KEYBOARD_OVERLAY_DELETE_WORD },
129 { "keyboardOverlayDeveloperTools", IDS_KEYBOARD_OVERLAY_DEVELOPER_TOOLS }, 116 { "keyboardOverlayDeveloperTools", IDS_KEYBOARD_OVERLAY_DEVELOPER_TOOLS },
130 { "keyboardOverlayDockWindowLeft", IDS_KEYBOARD_OVERLAY_DOCK_WINDOW_LEFT }, 117 { "keyboardOverlayDockWindowLeft", IDS_KEYBOARD_OVERLAY_DOCK_WINDOW_LEFT },
131 { "keyboardOverlayDockWindowRight", IDS_KEYBOARD_OVERLAY_DOCK_WINDOW_RIGHT }, 118 { "keyboardOverlayDockWindowRight", IDS_KEYBOARD_OVERLAY_DOCK_WINDOW_RIGHT },
132 { "keyboardOverlayDomInspector", IDS_KEYBOARD_OVERLAY_DOM_INSPECTOR }, 119 { "keyboardOverlayDomInspector", IDS_KEYBOARD_OVERLAY_DOM_INSPECTOR },
133 { "keyboardOverlayDownloads", IDS_KEYBOARD_OVERLAY_DOWNLOADS }, 120 { "keyboardOverlayDownloads", IDS_KEYBOARD_OVERLAY_DOWNLOADS },
134 { "keyboardOverlayEnd", IDS_KEYBOARD_OVERLAY_END }, 121 { "keyboardOverlayEnd", IDS_KEYBOARD_OVERLAY_END },
122 { "keyboardOverlayF1", IDS_KEYBOARD_OVERLAY_F1 },
123 { "keyboardOverlayF10", IDS_KEYBOARD_OVERLAY_F10 },
124 { "keyboardOverlayF11", IDS_KEYBOARD_OVERLAY_F11 },
125 { "keyboardOverlayF12", IDS_KEYBOARD_OVERLAY_F12 },
126 { "keyboardOverlayF2", IDS_KEYBOARD_OVERLAY_F2 },
127 { "keyboardOverlayF3", IDS_KEYBOARD_OVERLAY_F3 },
128 { "keyboardOverlayF4", IDS_KEYBOARD_OVERLAY_F4 },
129 { "keyboardOverlayF5", IDS_KEYBOARD_OVERLAY_F5 },
130 { "keyboardOverlayF6", IDS_KEYBOARD_OVERLAY_F6 },
131 { "keyboardOverlayF7", IDS_KEYBOARD_OVERLAY_F7 },
132 { "keyboardOverlayF8", IDS_KEYBOARD_OVERLAY_F8 },
133 { "keyboardOverlayF9", IDS_KEYBOARD_OVERLAY_F9 },
135 { "keyboardOverlayFindPreviousText", 134 { "keyboardOverlayFindPreviousText",
136 IDS_KEYBOARD_OVERLAY_FIND_PREVIOUS_TEXT }, 135 IDS_KEYBOARD_OVERLAY_FIND_PREVIOUS_TEXT },
137 { "keyboardOverlayFindText", IDS_KEYBOARD_OVERLAY_FIND_TEXT }, 136 { "keyboardOverlayFindText", IDS_KEYBOARD_OVERLAY_FIND_TEXT },
138 { "keyboardOverlayFindTextAgain", IDS_KEYBOARD_OVERLAY_FIND_TEXT_AGAIN }, 137 { "keyboardOverlayFindTextAgain", IDS_KEYBOARD_OVERLAY_FIND_TEXT_AGAIN },
139 { "keyboardOverlayFocusAddressBar", IDS_KEYBOARD_OVERLAY_FOCUS_ADDRESS_BAR }, 138 { "keyboardOverlayFocusAddressBar", IDS_KEYBOARD_OVERLAY_FOCUS_ADDRESS_BAR },
140 { "keyboardOverlayFocusAddressBarInSearchMode", 139 { "keyboardOverlayFocusAddressBarInSearchMode",
141 IDS_KEYBOARD_OVERLAY_FOCUS_ADDRESS_BAR_IN_SEARCH_MODE }, 140 IDS_KEYBOARD_OVERLAY_FOCUS_ADDRESS_BAR_IN_SEARCH_MODE },
142 { "keyboardOverlayFocusBookmarks", IDS_KEYBOARD_OVERLAY_FOCUS_BOOKMARKS }, 141 { "keyboardOverlayFocusBookmarks", IDS_KEYBOARD_OVERLAY_FOCUS_BOOKMARKS },
143 { "keyboardOverlayFocusLauncher", IDS_KEYBOARD_OVERLAY_FOCUS_LAUNCHER }, 142 { "keyboardOverlayFocusLauncher", IDS_KEYBOARD_OVERLAY_FOCUS_LAUNCHER },
144 { "keyboardOverlayFocusNextPane", IDS_KEYBOARD_OVERLAY_FOCUS_NEXT_PANE }, 143 { "keyboardOverlayFocusNextPane", IDS_KEYBOARD_OVERLAY_FOCUS_NEXT_PANE },
145 { "keyboardOverlayFocusPreviousPane", 144 { "keyboardOverlayFocusPreviousPane",
146 IDS_KEYBOARD_OVERLAY_FOCUS_PREVIOUS_PANE }, 145 IDS_KEYBOARD_OVERLAY_FOCUS_PREVIOUS_PANE },
147 { "keyboardOverlayFocusToolbar", IDS_KEYBOARD_OVERLAY_FOCUS_TOOLBAR }, 146 { "keyboardOverlayFocusToolbar", IDS_KEYBOARD_OVERLAY_FOCUS_TOOLBAR },
148 { "keyboardOverlayFullScreen", IDS_KEYBOARD_OVERLAY_FULL_SCREEN }, 147 { "keyboardOverlayFullScreen", IDS_KEYBOARD_OVERLAY_FULL_SCREEN },
149 { "keyboardOverlayGoBack", IDS_KEYBOARD_OVERLAY_GO_BACK }, 148 { "keyboardOverlayGoBack", IDS_KEYBOARD_OVERLAY_GO_BACK },
150 { "keyboardOverlayGoForward", IDS_KEYBOARD_OVERLAY_GO_FORWARD }, 149 { "keyboardOverlayGoForward", IDS_KEYBOARD_OVERLAY_GO_FORWARD },
151 { "keyboardOverlayHelp", IDS_KEYBOARD_OVERLAY_HELP }, 150 { "keyboardOverlayHelp", IDS_KEYBOARD_OVERLAY_HELP },
152 { "keyboardOverlayHistory", IDS_KEYBOARD_OVERLAY_HISTORY }, 151 { "keyboardOverlayHistory", IDS_KEYBOARD_OVERLAY_HISTORY },
153 { "keyboardOverlayHome", IDS_KEYBOARD_OVERLAY_HOME }, 152 { "keyboardOverlayHome", IDS_KEYBOARD_OVERLAY_HOME },
154 { "keyboardOverlayIncreaseKeyBrightness", 153 { "keyboardOverlayIncreaseKeyBrightness",
155 IDS_KEYBOARD_OVERLAY_INCREASE_KEY_BRIGHTNESS }, 154 IDS_KEYBOARD_OVERLAY_INCREASE_KEY_BRIGHTNESS },
156 { "keyboardOverlayInputUnicodeCharacters", 155 { "keyboardOverlayInputUnicodeCharacters",
157 IDS_KEYBOARD_OVERLAY_INPUT_UNICODE_CHARACTERS }, 156 IDS_KEYBOARD_OVERLAY_INPUT_UNICODE_CHARACTERS },
157 { "keyboardOverlayInsert", IDS_KEYBOARD_OVERLAY_INSERT },
158 { "keyboardOverlayJavascriptConsole", 158 { "keyboardOverlayJavascriptConsole",
159 IDS_KEYBOARD_OVERLAY_JAVASCRIPT_CONSOLE }, 159 IDS_KEYBOARD_OVERLAY_JAVASCRIPT_CONSOLE },
160 { "keyboardOverlayLockScreen", IDS_KEYBOARD_OVERLAY_LOCK_SCREEN }, 160 { "keyboardOverlayLockScreen", IDS_KEYBOARD_OVERLAY_LOCK_SCREEN },
161 { "keyboardOverlayLockScreenOrPowerOff", 161 { "keyboardOverlayLockScreenOrPowerOff",
162 IDS_KEYBOARD_OVERLAY_LOCK_SCREEN_OR_POWER_OFF }, 162 IDS_KEYBOARD_OVERLAY_LOCK_SCREEN_OR_POWER_OFF },
163 { "keyboardOverlayMagnifierDecreaseZoom", 163 { "keyboardOverlayMagnifierDecreaseZoom",
164 IDS_KEYBOARD_OVERLAY_MAGNIFIER_DECREASE_ZOOM }, 164 IDS_KEYBOARD_OVERLAY_MAGNIFIER_DECREASE_ZOOM },
165 { "keyboardOverlayMagnifierIncreaseZoom", 165 { "keyboardOverlayMagnifierIncreaseZoom",
166 IDS_KEYBOARD_OVERLAY_MAGNIFIER_INCREASE_ZOOM }, 166 IDS_KEYBOARD_OVERLAY_MAGNIFIER_INCREASE_ZOOM },
167 { "keyboardOverlayMaximizeWindow", IDS_KEYBOARD_OVERLAY_MAXIMIZE_WINDOW }, 167 { "keyboardOverlayMaximizeWindow", IDS_KEYBOARD_OVERLAY_MAXIMIZE_WINDOW },
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
372 372
373 KeyboardOverlayUI::KeyboardOverlayUI(content::WebUI* web_ui) 373 KeyboardOverlayUI::KeyboardOverlayUI(content::WebUI* web_ui)
374 : WebDialogUI(web_ui) { 374 : WebDialogUI(web_ui) {
375 Profile* profile = Profile::FromWebUI(web_ui); 375 Profile* profile = Profile::FromWebUI(web_ui);
376 KeyboardOverlayHandler* handler = new KeyboardOverlayHandler(profile); 376 KeyboardOverlayHandler* handler = new KeyboardOverlayHandler(profile);
377 web_ui->AddMessageHandler(handler); 377 web_ui->AddMessageHandler(handler);
378 378
379 // Set up the chrome://keyboardoverlay/ source. 379 // Set up the chrome://keyboardoverlay/ source.
380 content::WebUIDataSource::Add(profile, CreateKeyboardOverlayUIHTMLSource()); 380 content::WebUIDataSource::Add(profile, CreateKeyboardOverlayUIHTMLSource());
381 } 381 }
OLDNEW
« no previous file with comments | « chrome/browser/resources/chromeos/keyboard_overlay_data.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698