Remove DownloadItem::Is*() in favor of DI::GetState()

Remove DownloadItem::Is*() in favor of DI::GetState()

Rationale here is that we don't need two different ways of getting the
same state information.

BUG=241141
TEST=browser_tests/unit_tests/content_unittests w/ *Download*:*SavePage*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206604

[cmarcelo, 2013-06-13 18:46:17]

With this patch we close http://crbug.com/241141. Could you take a look?

benjhayden: main reviewer & content/browser/download
bauerb: chrome/browser/ui/webui
bulach: content/browser/android
joi: content/public
phajdan.jr: content/public/test

[benjhayden, 2013-06-13 19:01:45]

https://codereview.chromium.org/16994004/diff/1/content/browser/download/down...
File content/browser/download/download_item_impl.cc (right):

https://codereview.chromium.org/16994004/diff/1/content/browser/download/down...
content/browser/download/download_item_impl.cc:690: const bool isComplete =
GetState() == DownloadItem::COMPLETE;
use hacker_style for variable names: is_complete

https://codereview.chromium.org/16994004/diff/1/content/browser/download/down...
File content/browser/download/download_manager_impl_unittest.cc (left):

https://codereview.chromium.org/16994004/diff/1/content/browser/download/down...
content/browser/download/download_manager_impl_unittest.cc:119:
MOCK_CONST_METHOD0(IsCancelled, bool());
Also remove IsCancelled, IsInterrupted, IsComplete?

https://codereview.chromium.org/16994004/diff/1/content/browser/download/drag...
File content/browser/download/drag_download_file.cc (right):

https://codereview.chromium.org/16994004/diff/1/content/browser/download/drag...
content/browser/download/drag_download_file.cc:127: const bool isComplete =
is_complete

https://codereview.chromium.org/16994004/diff/1/content/public/test/mock_down...
File content/public/test/mock_download_item.h (left):

https://codereview.chromium.org/16994004/diff/1/content/public/test/mock_down...
content/public/test/mock_download_item.h:43: MOCK_CONST_METHOD0(IsCancelled,
bool());
Also remove IsCancelled, IsInterrupted, IsComplete?

[Bernhard Bauer, 2013-06-13 19:07:22]

WebUI LGTM, with a suggestion:

https://codereview.chromium.org/16994004/diff/1/chrome/browser/ui/webui/downl...
File chrome/browser/ui/webui/downloads_dom_handler.cc (right):

https://codereview.chromium.org/16994004/diff/1/chrome/browser/ui/webui/downl...
chrome/browser/ui/webui/downloads_dom_handler.cc:361: if (!file || !web_contents
||
It might be slightly more readable if you break this up into individual checks.
Then you could also move them directly after the declaration of the parameter
they're testing.

[cmarcelo, 2013-06-13 20:13:19]

Rebased to fix new test added, applied suggestions from bauerb and benjhayden.

[benjhayden, 2013-06-13 20:32:39]

lgtm

[bulach, 2013-06-14 09:21:30]

lgtm for android/

[Jói, 2013-06-14 12:57:57]

LGTM for //content/public.

[Paweł Hajdan Jr., 2013-06-14 17:54:18]

content/public/test LGTM

[commit-bot: I haz the power, 2013-06-14 17:58:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caio.de.oliveira.filho@intel.com/16994...

[commit-bot: I haz the power, 2013-06-15 00:49:50]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-06-15 14:27:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caio.de.oliveira.filho@intel.com/16994...

[commit-bot: I haz the power, 2013-06-15 17:08:51]

Change committed as 206604