content/browser/download/download_item_impl.h - Issue 16994004: Remove DownloadItem::Is*() in favor of DI::GetState()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_item_impl.h

Issue 16994004: Remove DownloadItem::Is*() in favor of DI::GetState() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@di-getstate-2

Patch Set: Rebased to fix new test, applied suggestions from bauerb and benjhayden Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/download/download_item_impl.h

diff --git a/content/browser/download/download_item_impl.h b/content/browser/download/download_item_impl.h

index 08e2dee6b021324dbf0d98207905735aff076a67..09d3f42b6217adeb98f45cf210247db371a1fda4 100644

--- a/content/browser/download/download_item_impl.h

+++ b/content/browser/download/download_item_impl.h

@@ -107,10 +107,6 @@ class CONTENT_EXPORT DownloadItemImpl

virtual bool IsTemporary() const OVERRIDE;

virtual bool CanResume() const OVERRIDE;

virtual bool IsDone() const OVERRIDE;

- virtual bool IsInProgress() const OVERRIDE;

- virtual bool IsCancelled() const OVERRIDE;

- virtual bool IsInterrupted() const OVERRIDE;

- virtual bool IsComplete() const OVERRIDE;

virtual const GURL& GetURL() const OVERRIDE;

virtual const std::vector<GURL>& GetUrlChain() const OVERRIDE;

virtual const GURL& GetOriginalUrl() const OVERRIDE;

« no previous file with comments | « content/browser/android/download_controller_android_impl.cc ('k') | content/browser/download/download_item_impl.cc » ('j') | no next file with comments »