Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1548)

Unified Diff: content/public/browser/download_item.h

Issue 16994004: Remove DownloadItem::Is*() in favor of DI::GetState() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@di-getstate-2
Patch Set: Rebased to fix new test, applied suggestions from bauerb and benjhayden Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/download/save_package.cc ('k') | content/public/test/mock_download_item.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/download_item.h
diff --git a/content/public/browser/download_item.h b/content/public/browser/download_item.h
index 11b2b16c108172fb6f53ccca9b9e1eef63a89788..4c6d0b735add46d72689fc04aba8a730ac61e8b7 100644
--- a/content/public/browser/download_item.h
+++ b/content/public/browser/download_item.h
@@ -175,20 +175,6 @@ class CONTENT_EXPORT DownloadItem : public base::SupportsUserData {
// can't be resumed.
virtual bool IsDone() const = 0;
- // Convenience routines for accessing GetState() results conceptually -----
-
- // Returns true if the download is still receiving data.
- virtual bool IsInProgress() const = 0;
-
- // Returns true if the download has been cancelled or was interrupted.
- virtual bool IsCancelled() const = 0;
-
- // Returns true if the download was interrupted.
- virtual bool IsInterrupted() const = 0;
-
- // Returns true if we have all the data and know the final file name.
- virtual bool IsComplete() const = 0;
-
// Origin State accessors -------------------------------------------------
virtual const GURL& GetURL() const = 0;
« no previous file with comments | « content/browser/download/save_package.cc ('k') | content/public/test/mock_download_item.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698