chrome/browser/net/chrome_network_delegate_unittest.cc - Issue 1694063002: Use GURLS instead of patterns in SetCookieSetting()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/chrome_network_delegate_unittest.cc

Issue 1694063002: Use GURLS instead of patterns in SetCookieSetting() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@scoping_set_content_setting

Patch Set: remove unused patterns Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_special_storage_policy_unittest.cc ('k') | components/content_settings/core/browser/cookie_settings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/chrome_network_delegate_unittest.cc

diff --git a/chrome/browser/net/chrome_network_delegate_unittest.cc b/chrome/browser/net/chrome_network_delegate_unittest.cc

index 868e53ded05fb65c823bd541543601a30f93fff5..b6feec34a4ef3ebc72e4b536a11628e704cdb524 100644

--- a/chrome/browser/net/chrome_network_delegate_unittest.cc

+++ b/chrome/browser/net/chrome_network_delegate_unittest.cc

@@ -499,10 +499,7 @@ TEST_F(ChromeNetworkDelegatePrivacyModeTest, EnablePrivacyIfCookiesBlocked) {

EXPECT_FALSE(network_delegate_->CanEnablePrivacyMode(kBlockedSite,

kEmptyFirstPartySite));

- cookie_settings_->SetCookieSetting(

- ContentSettingsPattern::FromURL(kBlockedSite),

- ContentSettingsPattern::Wildcard(),

- CONTENT_SETTING_BLOCK);

+ cookie_settings_->SetCookieSetting(kBlockedSite, CONTENT_SETTING_BLOCK);

EXPECT_TRUE(network_delegate_->CanEnablePrivacyMode(kBlockedSite,

kEmptyFirstPartySite));

}

@@ -530,10 +527,8 @@ TEST_F(ChromeNetworkDelegatePrivacyModeTest,

EXPECT_FALSE(network_delegate_->CanEnablePrivacyMode(kAllowedSite,

kBlockedFirstPartySite));

- cookie_settings_->SetCookieSetting(

- ContentSettingsPattern::FromURL(kBlockedFirstPartySite),

- ContentSettingsPattern::Wildcard(),

- CONTENT_SETTING_BLOCK);

+ cookie_settings_->SetCookieSetting(kBlockedFirstPartySite,

+ CONTENT_SETTING_BLOCK);

// Privacy mode is disabled as kAllowedSite is still getting cookies

EXPECT_FALSE(network_delegate_->CanEnablePrivacyMode(kAllowedSite,

kBlockedFirstPartySite));