Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Side by Side Diff: chrome/browser/net/chrome_network_delegate_unittest.cc

Issue 1694063002: Use GURLS instead of patterns in SetCookieSetting() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@scoping_set_content_setting
Patch Set: remove unused patterns Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/net/chrome_network_delegate.h" 5 #include "chrome/browser/net/chrome_network_delegate.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 481 matching lines...) Expand 10 before | Expand all | Expand 10 after
492 } 492 }
493 493
494 494
495 TEST_F(ChromeNetworkDelegatePrivacyModeTest, EnablePrivacyIfCookiesBlocked) { 495 TEST_F(ChromeNetworkDelegatePrivacyModeTest, EnablePrivacyIfCookiesBlocked) {
496 scoped_ptr<ChromeNetworkDelegate> delegate(CreateNetworkDelegate()); 496 scoped_ptr<ChromeNetworkDelegate> delegate(CreateNetworkDelegate());
497 SetDelegate(delegate.get()); 497 SetDelegate(delegate.get());
498 498
499 EXPECT_FALSE(network_delegate_->CanEnablePrivacyMode(kBlockedSite, 499 EXPECT_FALSE(network_delegate_->CanEnablePrivacyMode(kBlockedSite,
500 kEmptyFirstPartySite)); 500 kEmptyFirstPartySite));
501 501
502 cookie_settings_->SetCookieSetting( 502 cookie_settings_->SetCookieSetting(kBlockedSite, CONTENT_SETTING_BLOCK);
503 ContentSettingsPattern::FromURL(kBlockedSite),
504 ContentSettingsPattern::Wildcard(),
505 CONTENT_SETTING_BLOCK);
506 EXPECT_TRUE(network_delegate_->CanEnablePrivacyMode(kBlockedSite, 503 EXPECT_TRUE(network_delegate_->CanEnablePrivacyMode(kBlockedSite,
507 kEmptyFirstPartySite)); 504 kEmptyFirstPartySite));
508 } 505 }
509 506
510 TEST_F(ChromeNetworkDelegatePrivacyModeTest, EnablePrivacyIfThirdPartyBlocked) { 507 TEST_F(ChromeNetworkDelegatePrivacyModeTest, EnablePrivacyIfThirdPartyBlocked) {
511 scoped_ptr<ChromeNetworkDelegate> delegate(CreateNetworkDelegate()); 508 scoped_ptr<ChromeNetworkDelegate> delegate(CreateNetworkDelegate());
512 SetDelegate(delegate.get()); 509 SetDelegate(delegate.get());
513 510
514 EXPECT_FALSE(network_delegate_->CanEnablePrivacyMode(kAllowedSite, 511 EXPECT_FALSE(network_delegate_->CanEnablePrivacyMode(kAllowedSite,
515 kFirstPartySite)); 512 kFirstPartySite));
516 513
517 profile_.GetPrefs()->SetBoolean(prefs::kBlockThirdPartyCookies, true); 514 profile_.GetPrefs()->SetBoolean(prefs::kBlockThirdPartyCookies, true);
518 EXPECT_TRUE(network_delegate_->CanEnablePrivacyMode(kAllowedSite, 515 EXPECT_TRUE(network_delegate_->CanEnablePrivacyMode(kAllowedSite,
519 kFirstPartySite)); 516 kFirstPartySite));
520 profile_.GetPrefs()->SetBoolean(prefs::kBlockThirdPartyCookies, false); 517 profile_.GetPrefs()->SetBoolean(prefs::kBlockThirdPartyCookies, false);
521 EXPECT_FALSE(network_delegate_->CanEnablePrivacyMode(kAllowedSite, 518 EXPECT_FALSE(network_delegate_->CanEnablePrivacyMode(kAllowedSite,
522 kFirstPartySite)); 519 kFirstPartySite));
523 } 520 }
524 521
525 TEST_F(ChromeNetworkDelegatePrivacyModeTest, 522 TEST_F(ChromeNetworkDelegatePrivacyModeTest,
526 DisablePrivacyIfOnlyFirstPartyBlocked) { 523 DisablePrivacyIfOnlyFirstPartyBlocked) {
527 scoped_ptr<ChromeNetworkDelegate> delegate(CreateNetworkDelegate()); 524 scoped_ptr<ChromeNetworkDelegate> delegate(CreateNetworkDelegate());
528 SetDelegate(delegate.get()); 525 SetDelegate(delegate.get());
529 526
530 EXPECT_FALSE(network_delegate_->CanEnablePrivacyMode(kAllowedSite, 527 EXPECT_FALSE(network_delegate_->CanEnablePrivacyMode(kAllowedSite,
531 kBlockedFirstPartySite)); 528 kBlockedFirstPartySite));
532 529
533 cookie_settings_->SetCookieSetting( 530 cookie_settings_->SetCookieSetting(kBlockedFirstPartySite,
534 ContentSettingsPattern::FromURL(kBlockedFirstPartySite), 531 CONTENT_SETTING_BLOCK);
535 ContentSettingsPattern::Wildcard(),
536 CONTENT_SETTING_BLOCK);
537 // Privacy mode is disabled as kAllowedSite is still getting cookies 532 // Privacy mode is disabled as kAllowedSite is still getting cookies
538 EXPECT_FALSE(network_delegate_->CanEnablePrivacyMode(kAllowedSite, 533 EXPECT_FALSE(network_delegate_->CanEnablePrivacyMode(kAllowedSite,
539 kBlockedFirstPartySite)); 534 kBlockedFirstPartySite));
540 } 535 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698