components/content_settings/core/browser/cookie_settings.h - Issue 1694063002: Use GURLS instead of patterns in SetCookieSetting()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/browser/cookie_settings.h

Issue 1694063002: Use GURLS instead of patterns in SetCookieSetting() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@scoping_set_content_setting

Patch Set: remove unused patterns Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/net/chrome_network_delegate_unittest.cc ('k') | components/content_settings/core/browser/cookie_settings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/browser/cookie_settings.h

diff --git a/components/content_settings/core/browser/cookie_settings.h b/components/content_settings/core/browser/cookie_settings.h

index f3c627915fa3f541f30f6ac52b4754888693cf66..26ffa8068bacc6f85d71e4f76853652c36457e16 100644

--- a/components/content_settings/core/browser/cookie_settings.h

+++ b/components/content_settings/core/browser/cookie_settings.h

@@ -77,12 +77,10 @@ class CookieSettings : public RefcountedKeyedService {

// This should only be called on the UI thread.

void SetDefaultCookieSetting(ContentSetting setting);

- // Sets the cookie setting for the given patterns.

+ // Sets the cookie setting for the given url.

// This should only be called on the UI thread.

- void SetCookieSetting(const ContentSettingsPattern& primary_pattern,

- const ContentSettingsPattern& secondary_pattern,

- ContentSetting setting);

+ void SetCookieSetting(const GURL& primary_url, ContentSetting setting);

// Resets the cookie setting for the given url.