Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16629005: Use a direct include of strings headers in chrome/browser/ui/b*-p*/. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, jennb, tfarina, jeremya+watch_chromium.org, Dmitry Titov, dcheng, jianli, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Use a direct include of strings headers in chrome/browser/ui/b*-p*/. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205396

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -49 lines) Patch
M chrome/browser/ui/bookmarks/bookmark_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_close_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_focus_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/chrome_pages.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/chrome_select_file_policy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/confirm_bubble_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/extensions/app_metro_infobar_delegate_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/find_bar/find_backend_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_state.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/find_bar/find_bar_state_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_exit_bubble_type.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/global_error/global_error.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/hung_plugin_tab_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/select_file_dialog_impl_kde.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/login/login_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/action_box_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/location_bar.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/location_bar_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/location_bar_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_popup_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/native_panel_stack_window.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/pdf/open_pdf_in_reader_prompt_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/pdf/pdf_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16629005/1
7 years, 6 months ago (2013-06-10 16:44:10 UTC) #1
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=160535
7 years, 6 months ago (2013-06-10 19:29:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16629005/1
7 years, 6 months ago (2013-06-10 19:40:17 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 04:06:39 UTC) #4
Message was sent while issue was closed. 
Change committed as 205396

Powered by Google App Engine
This is Rietveld 408576698