chrome/browser/ui/find_bar/find_bar_host_browsertest.cc - Issue 16629005: Use a direct include of strings headers in chrome/browser/ui/b*-p*/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

Issue 16629005: Use a direct include of strings headers in chrome/browser/ui/b*-p*/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/ui/find_bar/find_bar.h ('k') | chrome/browser/ui/find_bar/find_bar_state.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/file_util.h"	5 #include "base/file_util.h"

6 #include "base/message_loop.h"	6 #include "base/message_loop.h"

7 #include "base/string16.h"	7 #include "base/strings/string16.h"

8 #include "base/string_util.h"	8 #include "base/strings/string_util.h"

9 #include "base/strings/utf_string_conversions.h"	9 #include "base/strings/utf_string_conversions.h"

10 #include "chrome/browser/common/cancelable_request.h"	10 #include "chrome/browser/common/cancelable_request.h"

11 #include "chrome/browser/history/history_service.h"	11 #include "chrome/browser/history/history_service.h"

12 #include "chrome/browser/history/history_service_factory.h"	12 #include "chrome/browser/history/history_service_factory.h"

13 #include "chrome/browser/profiles/profile.h"	13 #include "chrome/browser/profiles/profile.h"

14 #include "chrome/browser/ui/browser.h"	14 #include "chrome/browser/ui/browser.h"

15 #include "chrome/browser/ui/browser_commands.h"	15 #include "chrome/browser/ui/browser_commands.h"

16 #include "chrome/browser/ui/browser_finder.h"	16 #include "chrome/browser/ui/browser_finder.h"

17 #include "chrome/browser/ui/browser_navigator.h"	17 #include "chrome/browser/ui/browser_navigator.h"

18 #include "chrome/browser/ui/browser_tabstrip.h"	18 #include "chrome/browser/ui/browser_tabstrip.h"

(...skipping 1523 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1542 browser()->tab_strip_model()->GetActiveWebContents();	1542 browser()->tab_strip_model()->GetActiveWebContents();

1543 FindInPageWchar(web_contents_1, L"page", kFwd, kIgnoreCase, NULL);	1543 FindInPageWchar(web_contents_1, L"page", kFwd, kIgnoreCase, NULL);

1544 EXPECT_EQ(ASCIIToUTF16("page"), GetFindBarText());	1544 EXPECT_EQ(ASCIIToUTF16("page"), GetFindBarText());

1545 WebContents* web_contents_2 =	1545 WebContents* web_contents_2 =

1546 browser_incognito->tab_strip_model()->GetActiveWebContents();	1546 browser_incognito->tab_strip_model()->GetActiveWebContents();

1547 FindInPageWchar(web_contents_2, L"Incognito", kFwd, kIgnoreCase, NULL);	1547 FindInPageWchar(web_contents_2, L"Incognito", kFwd, kIgnoreCase, NULL);

1548 EXPECT_EQ(ASCIIToUTF16("Incognito"),	1548 EXPECT_EQ(ASCIIToUTF16("Incognito"),

1549 GetFindBarTextForBrowser(browser_incognito));	1549 GetFindBarTextForBrowser(browser_incognito));

1550 EXPECT_EQ(ASCIIToUTF16("page"), GetFindBarText());	1550 EXPECT_EQ(ASCIIToUTF16("page"), GetFindBarText());

1551 }	1551 }

OLD	NEW