Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 16431004: Use a direct include of strings headers in chrome/browser/ui/a*/. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Raman Kakilate, sadrul, ben+watch_chromium.org, benquan, tfarina, ahutter, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Use a direct include of strings headers in chrome/browser/ui/a*/. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205680

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -42 lines) Patch
M chrome/browser/ui/android/android_about_app_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/chrome_http_auth_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/chrome_http_auth_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/login_prompt_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/validation_message_bubble_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/history.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/history_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/mixer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/search_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/search_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/search_webstore_result.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/term_break_iterator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/term_break_iterator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/tokenized_string.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/tokenized_string_char_iterator_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/tokenized_string_match.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_modal_dialogs/app_modal_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/event_rewriter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/event_rewriter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/browser_launcher_item_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item_tab.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_item_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/shell_window_launcher_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/screenshot_taker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/account_chooser_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/account_chooser_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_models.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_models.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_types.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/country_combobox_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/data_model_wrapper.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16431004/1
7 years, 6 months ago (2013-06-10 16:41:51 UTC) #1
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=160477
7 years, 6 months ago (2013-06-10 18:18:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16431004/20001
7 years, 6 months ago (2013-06-11 20:01:46 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-11 21:32:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16431004/20001
7 years, 6 months ago (2013-06-11 21:33:57 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-12 00:17:53 UTC) #6
Message was sent while issue was closed.
Change committed as 205680

Powered by Google App Engine
This is Rietveld 408576698