Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: chrome/browser/ui/android/android_about_app_info.cc

Issue 16431004: Use a direct include of strings headers in chrome/browser/ui/a*/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/android/chrome_http_auth_handler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/android/android_about_app_info.h" 5 #include "chrome/browser/ui/android/android_about_app_info.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/stringprintf.h" 9 #include "base/strings/stringprintf.h"
10 #include "base/sys_info.h" 10 #include "base/sys_info.h"
11 #include "v8/include/v8.h" 11 #include "v8/include/v8.h"
12 12
13 std::string AndroidAboutAppInfo::GetOsInfo() { 13 std::string AndroidAboutAppInfo::GetOsInfo() {
14 std::string android_info_str; 14 std::string android_info_str;
15 15
16 // Append information about the OS version. 16 // Append information about the OS version.
17 int32 os_major_version = 0; 17 int32 os_major_version = 0;
18 int32 os_minor_version = 0; 18 int32 os_minor_version = 0;
19 int32 os_bugfix_version = 0; 19 int32 os_bugfix_version = 0;
(...skipping 22 matching lines...) Expand all
42 } 42 }
43 43
44 return android_info_str; 44 return android_info_str;
45 } 45 }
46 46
47 std::string AndroidAboutAppInfo::GetJavaScriptVersion() { 47 std::string AndroidAboutAppInfo::GetJavaScriptVersion() {
48 std::string js_version(v8::V8::GetVersion()); 48 std::string js_version(v8::V8::GetVersion());
49 std::string js_engine = "V8"; 49 std::string js_engine = "V8";
50 return js_engine + " " + js_version; 50 return js_engine + " " + js_version;
51 } 51 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/android/chrome_http_auth_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698