Cleanup usage of CSSPropertyID and CSSValueID inside Blink.

Cleanup usage of CSSPropertyID and CSSValueID inside Blink.

A lot of call sites were using integers to represent them. While it's
not incorrect per say, it's not ideal for various reason such as type
safety or to remove ambiguity.

This patch eradicate the wrong usage by not letting any integer based
API for getting CSSValueIDs or CSSPropertyIDs from CSSPrimitiveValues.

Instead we use new but typed functions to construct the values as well
as getting them. 2 custom and internal types were added to CSSPrimitiveValue
to handle correctly the new APIs.

It's good to note that in order to preserve compatibility on the
CSSPrimitiveValue type whenever CSSPrimitiveValue handles a CSSValueID
or a CSSPropertyID the return type for the public API will be CSS_IDENT
despite it is a separate internal type.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151975

[eseidel, 2013-06-06 19:41:16]

lgtm

This change is AMAZING.  Thank you.

https://codereview.chromium.org/16415007/diff/3001/Source/core/css/CSSParserV...
File Source/core/css/CSSParserValues.cpp (left):

https://codereview.chromium.org/16415007/diff/3001/Source/core/css/CSSParserV...
Source/core/css/CSSParserValues.cpp:81: case CSSPrimitiveValue::CSS_IDENT:
Is CSSPrimativeValue an internal-class or a CSSOM class?  Or shared?  It appears
we're adding non-standard unit-types, if this is intenral, we should remove
CSS_IDENT since it's not how we do things internally anymore. :)

https://codereview.chromium.org/16415007/diff/3001/Source/core/css/MediaQuery...
File Source/core/css/MediaQueryEvaluator.cpp (right):

https://codereview.chromium.org/16415007/diff/3001/Source/core/css/MediaQuery...
Source/core/css/MediaQueryEvaluator.cpp:666: const CSSValueID id =
toCSSPrimitiveValue(value)->getValueID();
This local is very silly. :)

[darktears, 2013-06-06 19:47:35]

On 2013/06/06 19:41:16, eseidel wrote:
> lgtm
> 
> This change is AMAZING.  Thank you.
> 
>
https://codereview.chromium.org/16415007/diff/3001/Source/core/css/CSSParserV...
> File Source/core/css/CSSParserValues.cpp (left):
> 
>
https://codereview.chromium.org/16415007/diff/3001/Source/core/css/CSSParserV...
> Source/core/css/CSSParserValues.cpp:81: case CSSPrimitiveValue::CSS_IDENT:
> Is CSSPrimativeValue an internal-class or a CSSOM class?  Or shared?  It
appears
> we're adding non-standard unit-types, if this is intenral, we should remove
> CSS_IDENT since it's not how we do things internally anymore. :)

It is shared. It already contained internal and public types. For example :

// These next types are just used internally to allow us to translate back and
forth from CSSPrimitiveValues to CSSParserValues.
CSS_PARSER_OPERATOR = 103,
CSS_PARSER_INTEGER = 104,
CSS_PARSER_HEXCOLOR = 105,

This class is a real candidate to split public/private for sure.

I can't remove the CSS_IDENT enum value as it is used inside the
CSSPrimitiveValue.idl :

const unsigned short CSS_IDENT = 21; 

accessible with :

readonly attribute unsigned short primitiveType;

The enum defines in the IDL maps directly to the C++ class with the bindings,
I'm not sure I could make the binding not care about the existence of the enum
value or not, at then end for the public we need to return 21 that's all.

> 
>
https://codereview.chromium.org/16415007/diff/3001/Source/core/css/MediaQuery...
> File Source/core/css/MediaQueryEvaluator.cpp (right):
> 
>
https://codereview.chromium.org/16415007/diff/3001/Source/core/css/MediaQuery...
> Source/core/css/MediaQueryEvaluator.cpp:666: const CSSValueID id =
> toCSSPrimitiveValue(value)->getValueID();
> This local is very silly. :)

Yes will fix.

[commit-bot: I haz the power, 2013-06-06 19:54:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexis.menard@intel.com/16415007/13001

[commit-bot: I haz the power, 2013-06-06 20:06:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexis.menard@intel.com/16415007/13001

[commit-bot: I haz the power, 2013-06-06 23:05:12]

Change committed as 151975