Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: Source/core/css/MediaQueryExp.cpp

Issue 16415007: Cleanup usage of CSSPropertyID and CSSValueID inside Blink. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/MediaQueryEvaluator.cpp ('k') | Source/core/css/SVGCSSParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/MediaQueryExp.cpp
diff --git a/Source/core/css/MediaQueryExp.cpp b/Source/core/css/MediaQueryExp.cpp
index a0cedd406bca0dfcce3bb60a5fe87848d1bf90e2..1af4b574c12abe5285358a4049b2b4de8bbdb573 100644
--- a/Source/core/css/MediaQueryExp.cpp
+++ b/Source/core/css/MediaQueryExp.cpp
@@ -51,7 +51,7 @@ static inline bool featureWithCSSValueID(const AtomicString& mediaFeature, const
|| mediaFeature == MediaFeatureNames::scanMediaFeature;
}
-static inline bool featureWithValidIdent(const AtomicString& mediaFeature, int ident)
+static inline bool featureWithValidIdent(const AtomicString& mediaFeature, CSSValueID ident)
{
if (mediaFeature == MediaFeatureNames::orientationMediaFeature)
return ident == CSSValuePortrait || ident == CSSValueLandscape;
@@ -210,7 +210,7 @@ inline MediaQueryExp::MediaQueryExp(const AtomicString& mediaFeature, CSSParserV
// Media features that use CSSValueIDs.
if (featureWithCSSValueID(mediaFeature, value)) {
m_value = CSSPrimitiveValue::createIdentifier(value->id);
- if (!featureWithValidIdent(mediaFeature, toCSSPrimitiveValue(m_value.get())->getIdent()))
+ if (!featureWithValidIdent(mediaFeature, toCSSPrimitiveValue(m_value.get())->getValueID()))
m_value.clear();
}
« no previous file with comments | « Source/core/css/MediaQueryEvaluator.cpp ('k') | Source/core/css/SVGCSSParser.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698