Source/core/css/StylePropertySerializer.cpp - Issue 16415007: Cleanup usage of CSSPropertyID and CSSValueID inside Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/StylePropertySerializer.cpp

Issue 16415007: Cleanup usage of CSSPropertyID and CSSValueID inside Blink. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/StylePropertySerializer.cpp

diff --git a/Source/core/css/StylePropertySerializer.cpp b/Source/core/css/StylePropertySerializer.cpp

index be5ee79ea7be4e97998584306ff603cfad796b5c..41053f5d5aa417239173335a205d974626866d98 100644

--- a/Source/core/css/StylePropertySerializer.cpp

+++ b/Source/core/css/StylePropertySerializer.cpp

@@ -596,8 +596,8 @@ String StylePropertySerializer::getLayeredShorthandValue(const StylePropertyShor

if (value->isImplicitInitialValue() || yValue->isImplicitInitialValue())

continue;

- int xId = toCSSPrimitiveValue(value.get())->getIdent();

- int yId = toCSSPrimitiveValue(yValue.get())->getIdent();

+ CSSValueID xId = toCSSPrimitiveValue(value.get())->getValueID();

+ CSSValueID yId = toCSSPrimitiveValue(yValue.get())->getValueID();

if (xId != yId) {

if (xId == CSSValueRepeat && yId == CSSValueNoRepeat) {

useRepeatXShorthand = true;