|
|
Make sure to use CSSValueID and CSSPropertyID rather than integers.
This will ensure that types are enforced when passing arguments in various
css functions. Having a compile time check make sure that no mistakes
will be done over the type.
The parser was also patched to directly use CSSValueID over integers.
This patch also fixes various call sites abusing the usage of integers.
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151920
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+128 lines, -99 lines) |
Patch |
 |
M |
Source/core/css/CSSComputedStyleDeclaration.cpp
|
View
|
|
4 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
|
M |
Source/core/css/CSSGrammar.y.in
|
View
|
|
12 chunks |
+19 lines, -19 lines |
0 comments
|
Download
|
|
M |
Source/core/css/CSSParser.h
|
View
|
|
4 chunks |
+8 lines, -7 lines |
0 comments
|
Download
|
|
M |
Source/core/css/CSSParser.cpp
|
View
|
|
22 chunks |
+33 lines, -29 lines |
0 comments
|
Download
|
|
M |
Source/core/css/CSSParserValues.h
|
View
|
|
3 chunks |
+5 lines, -4 lines |
0 comments
|
Download
|
|
M |
Source/core/css/CSSPrimitiveValue.h
|
View
|
|
1 chunk |
+4 lines, -3 lines |
0 comments
|
Download
|
|
M |
Source/core/css/CSSValuePool.h
|
View
|
|
2 chunks |
+6 lines, -4 lines |
0 comments
|
Download
|
|
M |
Source/core/css/CSSValuePool.cpp
|
View
|
|
2 chunks |
+7 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/css/StylePropertySet.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/css/StylePropertySet.cpp
|
View
|
|
1 chunk |
+7 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/dom/StyledElement.h
|
View
|
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/dom/StyledElement.cpp
|
View
|
|
2 chunks |
+9 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/editing/EditingStyle.cpp
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
Source/core/editing/EditorCommand.cpp
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/html/HTMLElement.cpp
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
Source/core/html/HTMLFontElement.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/html/HTMLFontElement.cpp
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/html/HTMLTableElement.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
Source/core/html/track/TextTrackCue.h
|
View
|
|
2 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
Source/core/html/track/TextTrackCue.cpp
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|
Chromium Code Reviews
Issue
16339006:
Make sure to use CSSValueID and CSSPropertyID rather than integers. (Closed)
