Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Unified Diff: Source/core/html/HTMLFontElement.cpp

Issue 16339006: Make sure to use CSSValueID and CSSPropertyID rather than integers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLFontElement.h ('k') | Source/core/html/HTMLTableElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLFontElement.cpp
diff --git a/Source/core/html/HTMLFontElement.cpp b/Source/core/html/HTMLFontElement.cpp
index 56b7508a6eeaa183ef183e9cb61312693e5e5d60..9a11a697409a19fb8a5999cee3c11e0c4dda685e 100644
--- a/Source/core/html/HTMLFontElement.cpp
+++ b/Source/core/html/HTMLFontElement.cpp
@@ -143,7 +143,7 @@ static bool parseFontSize(const String& input, int& size)
return parseFontSize(input.characters16(), input.length(), size);
}
-bool HTMLFontElement::cssValueFromFontSizeNumber(const String& s, int& size)
+bool HTMLFontElement::cssValueFromFontSizeNumber(const String& s, CSSValueID& size)
{
int num = 0;
if (!parseFontSize(s, num))
@@ -188,7 +188,7 @@ bool HTMLFontElement::isPresentationAttribute(const QualifiedName& name) const
void HTMLFontElement::collectStyleForPresentationAttribute(const QualifiedName& name, const AtomicString& value, MutableStylePropertySet* style)
{
if (name == sizeAttr) {
- int size = 0;
+ CSSValueID size = CSSValueInvalid;
if (cssValueFromFontSizeNumber(value, size))
addPropertyToPresentationAttributeStyle(style, CSSPropertyFontSize, size);
} else if (name == colorAttr)
« no previous file with comments | « Source/core/html/HTMLFontElement.h ('k') | Source/core/html/HTMLTableElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698