Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: Source/core/editing/EditorCommand.cpp

Issue 16339006: Make sure to use CSSValueID and CSSPropertyID rather than integers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/EditingStyle.cpp ('k') | Source/core/html/HTMLElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/EditorCommand.cpp
diff --git a/Source/core/editing/EditorCommand.cpp b/Source/core/editing/EditorCommand.cpp
index 29ac4dc5ff3396c19b15520e5a8a64a3d5820210..5fcf7e24a6324c364a275aad56fa3eb3ee843699 100644
--- a/Source/core/editing/EditorCommand.cpp
+++ b/Source/core/editing/EditorCommand.cpp
@@ -121,7 +121,7 @@ static bool executeApplyStyle(Frame* frame, EditorCommandSource source, EditActi
return applyCommandToFrame(frame, source, action, style.get());
}
-static bool executeApplyStyle(Frame* frame, EditorCommandSource source, EditAction action, CSSPropertyID propertyID, int propertyValue)
+static bool executeApplyStyle(Frame* frame, EditorCommandSource source, EditAction action, CSSPropertyID propertyID, CSSValueID propertyValue)
{
RefPtr<MutableStylePropertySet> style = MutableStylePropertySet::create();
style->setProperty(propertyID, propertyValue);
@@ -418,7 +418,7 @@ static bool executeFontName(Frame* frame, Event*, EditorCommandSource source, co
static bool executeFontSize(Frame* frame, Event*, EditorCommandSource source, const String& value)
{
- int size;
+ CSSValueID size;
if (!HTMLFontElement::cssValueFromFontSizeNumber(value, size))
return false;
return executeApplyStyle(frame, source, EditActionChangeAttributes, CSSPropertyFontSize, size);
« no previous file with comments | « Source/core/editing/EditingStyle.cpp ('k') | Source/core/html/HTMLElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698