Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 16297002: Update media/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed)

Created:
7 years, 6 months ago by Ryan Sleevi
Modified:
7 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Update media/ to use scoped_refptr<T>::get() rather than implicit "operator T*" Linux fixes BUG=110610 TBR=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203650

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -188 lines) Patch
M media/audio/audio_device_thread.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M media/audio/audio_input_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_input_controller_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M media/audio/audio_manager_base.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M media/audio/audio_output_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_output_controller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/audio/audio_output_proxy_unittest.cc View 6 chunks +26 lines, -34 lines 0 comments Download
M media/audio/virtual_audio_input_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/virtual_audio_input_stream_unittest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M media/audio/virtual_audio_output_stream_unittest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M media/base/audio_renderer_mixer_input_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/base/audio_renderer_mixer_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M media/base/data_buffer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/decoder_buffer_queue.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/decoder_buffer_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M media/base/video_frame.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/video_frame_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M media/base/video_util_unittest.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M media/crypto/aes_decryptor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/crypto/aes_decryptor_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M media/filters/audio_renderer_impl.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M media/filters/decrypting_audio_decoder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/decrypting_audio_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/decrypting_demuxer_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/decrypting_demuxer_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/decrypting_video_decoder.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M media/filters/decrypting_video_decoder_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/fake_demuxer_stream_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M media/filters/fake_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/fake_video_decoder_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M media/filters/ffmpeg_video_decoder_unittest.cc View 1 9 chunks +14 lines, -14 lines 0 comments Download
M media/filters/gpu_video_decoder.cc View 1 6 chunks +8 lines, -7 lines 0 comments Download
M media/filters/opus_audio_decoder.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M media/filters/pipeline_integration_test_base.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M media/filters/skcanvas_video_renderer_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M media/filters/video_frame_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/video_frame_stream_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/video_renderer_base.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/video_renderer_base_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/vpx_video_decoder.cc View 1 4 chunks +9 lines, -9 lines 0 comments Download
M media/tools/demuxer_bench/demuxer_bench.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/player_x11/player_x11.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Ryan Sleevi
TBR
7 years, 6 months ago (2013-06-01 01:45:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/16297002/1
7 years, 6 months ago (2013-06-01 01:46:23 UTC) #2
commit-bot: I haz the power
Failed to apply patch for media/filters/ffmpeg_video_decoder.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 6 months ago (2013-06-01 01:46:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/16297002/5001
7 years, 6 months ago (2013-06-01 02:13:00 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-03 00:19:38 UTC) #5
Message was sent while issue was closed.
Change committed as 203650

Powered by Google App Engine
This is Rietveld 408576698