Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: media/base/decoder_buffer_unittest.cc

Issue 16297002: Update media/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « media/base/decoder_buffer_queue.cc ('k') | media/base/video_frame.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/string_util.h" 5 #include "base/string_util.h"
6 #include "media/base/decoder_buffer.h" 6 #include "media/base/decoder_buffer.h"
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 namespace media { 9 namespace media {
10 10
11 TEST(DecoderBufferTest, Constructors) { 11 TEST(DecoderBufferTest, Constructors) {
12 scoped_refptr<DecoderBuffer> buffer(new DecoderBuffer(0)); 12 scoped_refptr<DecoderBuffer> buffer(new DecoderBuffer(0));
13 EXPECT_TRUE(buffer->GetData()); 13 EXPECT_TRUE(buffer->GetData());
14 EXPECT_EQ(0, buffer->GetDataSize()); 14 EXPECT_EQ(0, buffer->GetDataSize());
15 EXPECT_FALSE(buffer->IsEndOfStream()); 15 EXPECT_FALSE(buffer->IsEndOfStream());
16 16
17 const int kTestSize = 10; 17 const int kTestSize = 10;
18 scoped_refptr<DecoderBuffer> buffer3(new DecoderBuffer(kTestSize)); 18 scoped_refptr<DecoderBuffer> buffer3(new DecoderBuffer(kTestSize));
19 ASSERT_TRUE(buffer3); 19 ASSERT_TRUE(buffer3.get());
20 EXPECT_EQ(kTestSize, buffer3->GetDataSize()); 20 EXPECT_EQ(kTestSize, buffer3->GetDataSize());
21 } 21 }
22 22
23 TEST(DecoderBufferTest, CreateEOSBuffer) { 23 TEST(DecoderBufferTest, CreateEOSBuffer) {
24 scoped_refptr<DecoderBuffer> buffer(DecoderBuffer::CreateEOSBuffer()); 24 scoped_refptr<DecoderBuffer> buffer(DecoderBuffer::CreateEOSBuffer());
25 EXPECT_TRUE(buffer->IsEndOfStream()); 25 EXPECT_TRUE(buffer->IsEndOfStream());
26 } 26 }
27 27
28 TEST(DecoderBufferTest, CopyFrom) { 28 TEST(DecoderBufferTest, CopyFrom) {
29 const uint8 kData[] = "hello"; 29 const uint8 kData[] = "hello";
30 const int kDataSize = arraysize(kData); 30 const int kDataSize = arraysize(kData);
31 scoped_refptr<DecoderBuffer> buffer2(DecoderBuffer::CopyFrom( 31 scoped_refptr<DecoderBuffer> buffer2(DecoderBuffer::CopyFrom(
32 reinterpret_cast<const uint8*>(&kData), kDataSize)); 32 reinterpret_cast<const uint8*>(&kData), kDataSize));
33 ASSERT_TRUE(buffer2); 33 ASSERT_TRUE(buffer2.get());
34 EXPECT_NE(kData, buffer2->GetData()); 34 EXPECT_NE(kData, buffer2->GetData());
35 EXPECT_EQ(buffer2->GetDataSize(), kDataSize); 35 EXPECT_EQ(buffer2->GetDataSize(), kDataSize);
36 EXPECT_EQ(0, memcmp(buffer2->GetData(), kData, kDataSize)); 36 EXPECT_EQ(0, memcmp(buffer2->GetData(), kData, kDataSize));
37 EXPECT_FALSE(buffer2->IsEndOfStream()); 37 EXPECT_FALSE(buffer2->IsEndOfStream());
38 scoped_refptr<DecoderBuffer> buffer3(DecoderBuffer::CopyFrom( 38 scoped_refptr<DecoderBuffer> buffer3(DecoderBuffer::CopyFrom(
39 reinterpret_cast<const uint8*>(&kData), kDataSize, 39 reinterpret_cast<const uint8*>(&kData), kDataSize,
40 reinterpret_cast<const uint8*>(&kData), kDataSize)); 40 reinterpret_cast<const uint8*>(&kData), kDataSize));
41 ASSERT_TRUE(buffer3); 41 ASSERT_TRUE(buffer3.get());
42 EXPECT_NE(kData, buffer3->GetData()); 42 EXPECT_NE(kData, buffer3->GetData());
43 EXPECT_EQ(buffer3->GetDataSize(), kDataSize); 43 EXPECT_EQ(buffer3->GetDataSize(), kDataSize);
44 EXPECT_EQ(0, memcmp(buffer3->GetData(), kData, kDataSize)); 44 EXPECT_EQ(0, memcmp(buffer3->GetData(), kData, kDataSize));
45 EXPECT_NE(kData, buffer3->GetSideData()); 45 EXPECT_NE(kData, buffer3->GetSideData());
46 EXPECT_EQ(buffer3->GetSideDataSize(), kDataSize); 46 EXPECT_EQ(buffer3->GetSideDataSize(), kDataSize);
47 EXPECT_EQ(0, memcmp(buffer3->GetSideData(), kData, kDataSize)); 47 EXPECT_EQ(0, memcmp(buffer3->GetSideData(), kData, kDataSize));
48 EXPECT_FALSE(buffer3->IsEndOfStream()); 48 EXPECT_FALSE(buffer3->IsEndOfStream());
49 } 49 }
50 50
51 #if !defined(OS_ANDROID) 51 #if !defined(OS_ANDROID)
52 TEST(DecoderBufferTest, PaddingAlignment) { 52 TEST(DecoderBufferTest, PaddingAlignment) {
53 const uint8 kData[] = "hello"; 53 const uint8 kData[] = "hello";
54 const int kDataSize = arraysize(kData); 54 const int kDataSize = arraysize(kData);
55 scoped_refptr<DecoderBuffer> buffer2(DecoderBuffer::CopyFrom( 55 scoped_refptr<DecoderBuffer> buffer2(DecoderBuffer::CopyFrom(
56 reinterpret_cast<const uint8*>(&kData), kDataSize)); 56 reinterpret_cast<const uint8*>(&kData), kDataSize));
57 ASSERT_TRUE(buffer2); 57 ASSERT_TRUE(buffer2.get());
58 58
59 // Padding data should always be zeroed. 59 // Padding data should always be zeroed.
60 for(int i = 0; i < DecoderBuffer::kPaddingSize; i++) 60 for(int i = 0; i < DecoderBuffer::kPaddingSize; i++)
61 EXPECT_EQ((buffer2->GetData() + kDataSize)[i], 0); 61 EXPECT_EQ((buffer2->GetData() + kDataSize)[i], 0);
62 62
63 // If the data is padded correctly we should be able to read and write past 63 // If the data is padded correctly we should be able to read and write past
64 // the end of the data by DecoderBuffer::kPaddingSize bytes without crashing 64 // the end of the data by DecoderBuffer::kPaddingSize bytes without crashing
65 // or Valgrind/ASAN throwing errors. 65 // or Valgrind/ASAN throwing errors.
66 const uint8 kFillChar = 0xFF; 66 const uint8 kFillChar = 0xFF;
67 memset( 67 memset(
68 buffer2->GetWritableData() + kDataSize, kFillChar, 68 buffer2->GetWritableData() + kDataSize, kFillChar,
69 DecoderBuffer::kPaddingSize); 69 DecoderBuffer::kPaddingSize);
70 for(int i = 0; i < DecoderBuffer::kPaddingSize; i++) 70 for(int i = 0; i < DecoderBuffer::kPaddingSize; i++)
71 EXPECT_EQ((buffer2->GetData() + kDataSize)[i], kFillChar); 71 EXPECT_EQ((buffer2->GetData() + kDataSize)[i], kFillChar);
72 72
73 EXPECT_EQ(0u, reinterpret_cast<uintptr_t>( 73 EXPECT_EQ(0u, reinterpret_cast<uintptr_t>(
74 buffer2->GetData()) & (DecoderBuffer::kAlignmentSize - 1)); 74 buffer2->GetData()) & (DecoderBuffer::kAlignmentSize - 1));
75 } 75 }
76 #endif 76 #endif
77 77
78 TEST(DecoderBufferTest, ReadingWriting) { 78 TEST(DecoderBufferTest, ReadingWriting) {
79 const char kData[] = "hello"; 79 const char kData[] = "hello";
80 const int kDataSize = arraysize(kData); 80 const int kDataSize = arraysize(kData);
81 81
82 scoped_refptr<DecoderBuffer> buffer(new DecoderBuffer(kDataSize)); 82 scoped_refptr<DecoderBuffer> buffer(new DecoderBuffer(kDataSize));
83 ASSERT_TRUE(buffer); 83 ASSERT_TRUE(buffer.get());
84 84
85 uint8* data = buffer->GetWritableData(); 85 uint8* data = buffer->GetWritableData();
86 ASSERT_TRUE(data); 86 ASSERT_TRUE(data);
87 ASSERT_EQ(kDataSize, buffer->GetDataSize()); 87 ASSERT_EQ(kDataSize, buffer->GetDataSize());
88 memcpy(data, kData, kDataSize); 88 memcpy(data, kData, kDataSize);
89 const uint8* read_only_data = buffer->GetData(); 89 const uint8* read_only_data = buffer->GetData();
90 ASSERT_EQ(data, read_only_data); 90 ASSERT_EQ(data, read_only_data);
91 ASSERT_EQ(0, memcmp(read_only_data, kData, kDataSize)); 91 ASSERT_EQ(0, memcmp(read_only_data, kData, kDataSize));
92 EXPECT_FALSE(buffer->IsEndOfStream()); 92 EXPECT_FALSE(buffer->IsEndOfStream());
93 } 93 }
94 94
95 TEST(DecoderBufferTest, GetDecryptConfig) { 95 TEST(DecoderBufferTest, GetDecryptConfig) {
96 scoped_refptr<DecoderBuffer> buffer(new DecoderBuffer(0)); 96 scoped_refptr<DecoderBuffer> buffer(new DecoderBuffer(0));
97 EXPECT_FALSE(buffer->GetDecryptConfig()); 97 EXPECT_FALSE(buffer->GetDecryptConfig());
98 } 98 }
99 99
100 } // namespace media 100 } // namespace media
OLDNEW
« no previous file with comments | « media/base/decoder_buffer_queue.cc ('k') | media/base/video_frame.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698