media/filters/fake_video_decoder.cc - Issue 16297002: Update media/ to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/fake_video_decoder.cc

Issue 16297002: Update media/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/filters/fake_video_decoder.cc

diff --git a/media/filters/fake_video_decoder.cc b/media/filters/fake_video_decoder.cc

index 95868d68ae5e3beca961a1a8645d170800da569d..bd3d8a7f62d23fd78f26c4058dbee9b7cb783dba 100644

--- a/media/filters/fake_video_decoder.cc

+++ b/media/filters/fake_video_decoder.cc

@@ -153,7 +153,7 @@ void FakeVideoDecoder::BufferReady(DemuxerStream::Status status,

DCHECK(message_loop_->BelongsToCurrentThread());

DCHECK_EQ(state_, NORMAL);

DCHECK(!read_cb_.IsNull());

- DCHECK_EQ(status != DemuxerStream::kOk, !buffer) << status;

+ DCHECK_EQ(status != DemuxerStream::kOk, !buffer.get()) << status;

if (!stop_cb_.IsNull()) {

read_cb_.RunOrHold(kOk, scoped_refptr<VideoFrame>());

« no previous file with comments | « media/filters/fake_demuxer_stream_unittest.cc ('k') | media/filters/fake_video_decoder_unittest.cc » ('j') | no next file with comments »