Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Issue 16282004: Remove unused includes from various .cpp files in core/ (Closed)

Created:
7 years, 6 months ago by Timothy Loh
Modified:
7 years, 6 months ago
Reviewers:
pdr.
CC:
blink-reviews, kenneth.christiansen, shans, gavinp+prerender_chromium.org, aboxhall, alancutter (OOO until 2018), eae+blinkwatch, kinuko, dstockwell, dmazzoni, gavinp+loader_chromium.org, darktears, Nate Chapin, Steve Block, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Remove unused includes from various .cpp files in core/ Splitting up codereview.chromium.org/15447002 into smaller patches. BUG=242216 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151749

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebased #

Patch Set 3 : fix for mac compile #

Patch Set 4 : fix for windows compile (PAN_SCROLLING) #

Patch Set 5 : rebased #

Patch Set 6 : second attempt at getting windows to compile... #

Patch Set 7 : re-add HTMLFormElement to EmptyClients for windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -251 lines) Patch
M Source/core/accessibility/AXObjectCache.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/animation/DocumentTimeline.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/AppendNodeCommand.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/ApplyBlockElementCommand.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/editing/CompositeEditCommand.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/editing/CreateLinkCommand.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/EditingStyle.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/EditorCommand.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/editing/FormatBlockCommand.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/FrameSelection.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/editing/IndentOutdentCommand.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/editing/InsertLineBreakCommand.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/InsertNodeBeforeCommand.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/InsertParagraphSeparatorCommand.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/InsertTextCommand.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/RenderedPosition.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/ReplaceSelectionCommand.cpp View 3 chunks +0 lines, -4 lines 0 comments Download
M Source/core/editing/SpellChecker.cpp View 1 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/editing/SpellingCorrectionCommand.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/editing/SurroundingText.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/TextInsertionBaseCommand.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/TextIterator.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/editing/TypingCommand.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/chromium/EditorChromium.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/htmlediting.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/fileapi/Blob.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/fileapi/BlobBuilder.cpp View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/fileapi/FileReaderSync.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/history/HistoryItem.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/DocumentLoadTiming.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/loader/DocumentThreadableLoader.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/loader/FormSubmission.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/loader/ImageLoader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/LinkLoader.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/loader/MixedContentChecker.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/loader/appcache/DOMApplicationCache.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/loader/archive/MHTMLArchive.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/cache/CachedCSSStyleSheet.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/cache/CachedImage.cpp View 1 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/loader/cache/CachedResourceRequest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/cache/CachedScript.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/loader/cache/CachedTextTrack.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/page/AutoscrollController.cpp View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/page/Chrome.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M Source/core/page/Console.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/page/ContextMenuController.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/page/DOMSecurityPolicy.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/page/DOMWindow.cpp View 4 chunks +0 lines, -8 lines 0 comments Download
M Source/core/page/DeviceController.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/DragController.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 3 chunks +0 lines, -7 lines 0 comments Download
M Source/core/page/EventSource.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/page/FocusController.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/page/MouseEventWithHitTestResults.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/Navigator.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/page/PageConsole.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/page/PageGroup.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/PageGroupLoadDeferrer.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/page/PageSerializer.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/page/Performance.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/PerformanceResourceTiming.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/PointerLockController.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/PrintContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/SpatialNavigation.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/page/SpeechInput.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/SuspendableTimer.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/page/TouchAdjustment.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/page/animation/AnimationController.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/animation/CSSPropertyAnimation.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/page/animation/CompositeAnimation.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/plugins/DOMMimeType.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/plugins/DOMMimeTypeArray.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/plugins/DOMPlugin.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/storage/Storage.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/testing/InternalSettings.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/testing/MockPagePopupDriver.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/workers/AbstractWorker.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/workers/DedicatedWorkerContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/workers/SharedWorkerContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/workers/WorkerEventQueue.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/workers/WorkerScriptLoader.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/xml/XMLErrors.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/xml/XMLHttpRequestUpload.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/xml/XMLTreeViewer.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/xml/XPathExpression.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/xml/XPathPredicate.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/xml/XPathResult.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/xml/XPathValue.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/xml/XPathVariableReference.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/xml/XSLStyleSheetLibxslt.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/xml/XSLTProcessor.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/xml/XSLTProcessorLibxslt.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.cpp View 3 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Timothy Loh
7 years, 6 months ago (2013-06-03 08:12:28 UTC) #1
pdr.
LGTM with nits. rs=me https://codereview.chromium.org/16282004/diff/1/Source/core/loader/DocumentThreadableLoader.cpp File Source/core/loader/DocumentThreadableLoader.cpp (left): https://codereview.chromium.org/16282004/diff/1/Source/core/loader/DocumentThreadableLoader.cpp#oldcode55 Source/core/loader/DocumentThreadableLoader.cpp:55: #include "wtf/UnusedParam.h" I think this ...
7 years, 6 months ago (2013-06-04 04:59:14 UTC) #2
Timothy Loh
https://codereview.chromium.org/16282004/diff/1/Source/core/loader/DocumentThreadableLoader.cpp File Source/core/loader/DocumentThreadableLoader.cpp (left): https://codereview.chromium.org/16282004/diff/1/Source/core/loader/DocumentThreadableLoader.cpp#oldcode55 Source/core/loader/DocumentThreadableLoader.cpp:55: #include "wtf/UnusedParam.h" On 2013/06/04 04:59:15, pdr wrote: > I ...
7 years, 6 months ago (2013-06-04 05:29:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/16282004/5001
7 years, 6 months ago (2013-06-04 05:35:58 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-04 05:55:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/16282004/18001
7 years, 6 months ago (2013-06-04 06:08:21 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-04 06:46:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/16282004/21003
7 years, 6 months ago (2013-06-04 06:59:59 UTC) #8
commit-bot: I haz the power
Failed to apply patch for Source/core/fileapi/BlobBuilder.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 6 months ago (2013-06-04 07:00:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/16282004/29001
7 years, 6 months ago (2013-06-04 08:29:15 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_lint, webkit_tests, webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=8558
7 years, 6 months ago (2013-06-04 09:16:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/16282004/30100
7 years, 6 months ago (2013-06-04 09:40:04 UTC) #12
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-04 10:23:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/16282004/31101
7 years, 6 months ago (2013-06-04 11:21:11 UTC) #14
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=8588
7 years, 6 months ago (2013-06-04 12:08:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/16282004/31101
7 years, 6 months ago (2013-06-04 12:18:38 UTC) #16
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=8597
7 years, 6 months ago (2013-06-04 13:40:09 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/16282004/31101
7 years, 6 months ago (2013-06-04 13:55:10 UTC) #18
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 14:20:46 UTC) #19
Message was sent while issue was closed.
Change committed as 151749

Powered by Google App Engine
This is Rietveld 408576698