Replace JSON (de)serialization of extension messages with direct Value pickling.

Replace JSON (de)serialization of extension messages with direct Value pickling.

BUG=55316
TBR=mpcomplete@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204067

[not at google - send to devlin, 2013-05-30 22:08:34]

mpcomplete for everything
cdn for extension_messages.h

[Matt Perry, 2013-05-30 23:06:03]

lgtm

[commit-bot: I haz the power, 2013-05-31 00:08:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/16226004/11001

[commit-bot: I haz the power, 2013-05-31 03:53:10]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-05-31 05:35:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/16226004/28001

[commit-bot: I haz the power, 2013-05-31 07:57:36]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-05-31 16:44:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/16226004/24002

[Sergey Ulanov, 2013-05-31 19:29:54]

https://codereview.chromium.org/16226004/diff/24002/chrome/browser/extensions...
File
chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc
(right):

https://codereview.chromium.org/16226004/diff/24002/chrome/browser/extensions...
chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc:199:
base::FilePath temp_input_file = CreateTempFileWithMessage(std::string());
This writes a zero-size message to the input file. Previously
NativeMessageProcessHost treated those messages as valid, but not anymore. It
fails on windows only because async IO in net::FileStream works differently.

[Sergey Ulanov, 2013-05-31 19:34:12]

I unchecked commit bit - I think the problem is not Windows-specific and the
test is likely to become flaky on Linux on Mac if you land it as is.

[not at google - send to devlin, 2013-05-31 19:51:59]

https://codereview.chromium.org/16226004/diff/24002/chrome/browser/extensions...
File
chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc
(right):

https://codereview.chromium.org/16226004/diff/24002/chrome/browser/extensions...
chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc:199:
base::FilePath temp_input_file = CreateTempFileWithMessage(std::string());
On 2013/05/31 19:29:54, Sergey Ulanov wrote:
> This writes a zero-size message to the input file. Previously
> NativeMessageProcessHost treated those messages as valid, but not anymore. It
> fails on windows only because async IO in net::FileStream works differently.

Done.

[commit-bot: I haz the power, 2013-05-31 19:52:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/16226004/58001

[commit-bot: I haz the power, 2013-05-31 21:52:59]

Change committed as 203489

[commit-bot: I haz the power, 2013-06-04 20:58:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/16226004/77001

[not at google - send to devlin, 2013-06-04 23:18:57]

Committed patchset #8 manually as r204067 (presubmit successful).