chrome/renderer/extensions/extension_helper.h - Issue 16226004: Replace JSON (de)serialization of extension messages with direct Value pickling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/extension_helper.h

Issue 16226004: Replace JSON (de)serialization of extension messages with direct Value pickling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/extensions/extension_helper.h

diff --git a/chrome/renderer/extensions/extension_helper.h b/chrome/renderer/extensions/extension_helper.h

index fcb82b144bfcaeb6764bbe440b5472e9e2b2e208..6e8fc9772264a077d6aab0b350d9e0eb82d33376 100644

--- a/chrome/renderer/extensions/extension_helper.h

+++ b/chrome/renderer/extensions/extension_helper.h

@@ -80,7 +80,7 @@ class ExtensionHelper

const base::DictionaryValue& source_tab,

const ExtensionMsg_ExternalConnectionInfo& info);

void OnExtensionDeliverMessage(int target_port_id,

- const std::string& message);

+ const base::ListValue& message);

void OnExtensionDispatchOnDisconnect(int port_id,

const std::string& error_message);

void OnExecuteCode(const ExtensionMsg_ExecuteCode_Params& params);

« no previous file with comments | « chrome/renderer/extensions/dispatcher.cc ('k') | chrome/renderer/extensions/extension_helper.cc » ('j') | no next file with comments »