chrome/browser/extensions/api/messaging/extension_message_port.cc - Issue 16226004: Replace JSON (de)serialization of extension messages with direct Value pickling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/extension_message_port.cc

Issue 16226004: Replace JSON (de)serialization of extension messages with direct Value pickling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/messaging/extension_message_port.h ('k') | chrome/browser/extensions/api/messaging/message_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/messaging/extension_message_port.cc

diff --git a/chrome/browser/extensions/api/messaging/extension_message_port.cc b/chrome/browser/extensions/api/messaging/extension_message_port.cc

index e4782c74f2d246165a5fe5d132c8cd76e3bb6d33..a3bba97dc2d9b4cacb06545df687dff11134f093 100644

--- a/chrome/browser/extensions/api/messaging/extension_message_port.cc

+++ b/chrome/browser/extensions/api/messaging/extension_message_port.cc

@@ -4,6 +4,7 @@

#include "chrome/browser/extensions/api/messaging/extension_message_port.h"

+#include "base/values.h"

#include "chrome/browser/extensions/extension_host.h"

#include "chrome/browser/extensions/extension_process_manager.h"

#include "chrome/browser/extensions/extension_system.h"

@@ -45,10 +46,11 @@ void ExtensionMessagePort::DispatchOnDisconnect(

routing_id_, source_port_id, error_message));

}

-void ExtensionMessagePort::DispatchOnMessage(const std::string& message,

- int target_port_id) {

- process_->Send(new ExtensionMsg_DeliverMessage(

- routing_id_, target_port_id, message));

+void ExtensionMessagePort::DispatchOnMessage(

+ scoped_ptr<base::ListValue> message,

+ int target_port_id) {

+ process_->Send(new ExtensionMsg_DeliverMessage(

+ routing_id_, target_port_id, *message));

}

void ExtensionMessagePort::IncrementLazyKeepaliveCount() {