Remove log filtering and add stringsetflag.

Remove log filtering and add stringsetflag.

Filtering was unused, and having a stringset flag is a generally useful.

R=dnj@chromium.org
BUG=

Committed: https://github.com/luci/luci-go/commit/413c0574cc738aaa1db2a7936c252ccaea134e84

[iannucci, 2016-01-23 01:27:22]

PTAL

[M-A Ruel, 2016-01-23 02:47:30]

Why is flag in common, not in client/common?

M-A
Le 22 janv. 2016 8:27 PM, <iannucci@chromium.org> a écrit :

> Reviewers: dnj
> CL: https://chromiumcodereview.appspot.com/1622553005/
>
> Message:
> PTAL
>
> Description:
> Remove log filtering and add stringsetflag.
>
> Filtering was unused, and having a stringset flag is a generally useful.
>
> R=dnj@chromium.org
> BUG=
>
> Base URL:
> https://chromium.googlesource.com/external/github.com/luci/luci-go@master
>
> Affected files (+103, -130 lines):
>   M appengine/cmd/dm/frontend/apigen.go
>   M appengine/cmd/milo/Makefile
>   A common/flag/stringsetflag/stringsetflag.go
>   A common/flag/stringsetflag/stringsetflag_test.go
>   M common/logging/cloudlog/logging.go
>   M common/logging/config.go
>   M common/logging/exported.go
>   M common/logging/fields.go
>   M common/logging/fields_test.go
>   D common/logging/filter.go
>   M common/logging/gologger/logger.go
>   M common/meter/meter.go
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dnj, 2016-01-23 02:50:56]

On 2016/01/23 02:47:30, M-A Ruel wrote:
> Why is flag in common, not in client/common?

I believe the rationale is that server software "e.g., server/" also needs to
use flags.

[M-A Ruel, 2016-01-23 02:52:15]

Ok

Wrote by human
Le 22 janv. 2016 9:50 PM, <dnj@chromium.org> a écrit :

> On 2016/01/23 02:47:30, M-A Ruel wrote:
>
>> Why is flag in common, not in client/common?
>>
>
> I believe the rationale is that server software "e.g., server/" also needs
> to
> use flags.
>
> https://chromiumcodereview.appspot.com/1622553005/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[iannucci, 2016-01-23 02:53:33]

Yes, it's so that server can use it too.

[dnj, 2016-01-23 02:55:38]

lgtm

[iannucci, 2016-01-23 06:01:05]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2016-01-23 06:01:06]

The patchset sent to the CQ was uploaded after l-g-t-m from dnj@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1622553005/#ps20001
(title: "error on empty")

[commit-bot: I haz the power, 2016-01-23 06:01:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1622553005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1622553005/20001

[commit-bot: I haz the power, 2016-01-23 06:02:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-23 06:02:26]

Try jobs failed on following builders:
  Luci-go Linux Precise 32 Tester on master.tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Luci-go%20Linux%20Preci...)
  Luci-go Linux Trusty 64 Tester on master.tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Luci-go%20Linux%20Trust...)

[dnj, 2016-01-23 06:05:31]

On 2016/01/23 06:02:26, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   Luci-go Linux Precise 32 Tester on master.tryserver.infra (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.infra/builders/Luci-go%20Linux%20Preci...)
>   Luci-go Linux Trusty 64 Tester on master.tryserver.infra (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.infra/builders/Luci-go%20Linux%20Trust...)

hah you broke gae

[iannucci, 2016-01-23 06:09:39]

On 2016/01/23 06:05:31, dnj wrote:
> On 2016/01/23 06:02:26, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   Luci-go Linux Precise 32 Tester on master.tryserver.infra (JOB_FAILED,
> >
>
https://build.chromium.org/p/tryserver.infra/builders/Luci-go%20Linux%20Preci...)
> >   Luci-go Linux Trusty 64 Tester on master.tryserver.infra (JOB_FAILED,
> >
>
https://build.chromium.org/p/tryserver.infra/builders/Luci-go%20Linux%20Trust...)
> 
> hah you broke gae

yeah I know... though I think I can actually fix it w/o a 3-way patch!

[iannucci, 2016-01-23 06:25:59]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2016-01-23 06:26:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1622553005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1622553005/20001

[commit-bot: I haz the power, 2016-01-23 06:29:13]

Description was changed from

==========
Remove log filtering and add stringsetflag.

Filtering was unused, and having a stringset flag is a generally useful.

R=dnj@chromium.org
BUG=
==========

to

==========
Remove log filtering and add stringsetflag.

Filtering was unused, and having a stringset flag is a generally useful.

R=dnj@chromium.org
BUG=

Committed:
https://github.com/luci/luci-go/commit/413c0574cc738aaa1db2a7936c252ccaea134e84
==========

[commit-bot: I haz the power, 2016-01-23 06:29:14]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/413c0574cc738aaa1db2a7936c252ccaea134e84