common/logging/cloudlog/logging.go - Issue 1622553005: Remove log filtering and add stringsetflag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: common/logging/cloudlog/logging.go

Issue 1622553005: Remove log filtering and add stringsetflag. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: error on empty Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: common/logging/cloudlog/logging.go

diff --git a/common/logging/cloudlog/logging.go b/common/logging/cloudlog/logging.go

index d3554de172981ac499a38639565c5f9b830e3e65..792a0539f0b9234fb1fd015b650189c70216458d 100644

--- a/common/logging/cloudlog/logging.go

+++ b/common/logging/cloudlog/logging.go

@@ -102,7 +102,7 @@ func (l *boundCloudLogger) LogCall(level logging.Level, calldepth int, f string,

text := fmt.Sprintf(f, args...)

fields := logging.GetFields(l.ctx)

if len(fields) > 0 {

- text = text + " " + fields.FieldString(true)

+ text = text + " " + fields.String()

}

// Add logging fields to labels.

« no previous file with comments | « common/flag/stringsetflag/stringsetflag_test.go ('k') | common/logging/config.go » ('j') | no next file with comments »