Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: common/logging/fields_test.go

Issue 1622553005: Remove log filtering and add stringsetflag. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Patch Set: error on empty Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « common/logging/fields.go ('k') | common/logging/filter.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: common/logging/fields_test.go
diff --git a/common/logging/fields_test.go b/common/logging/fields_test.go
index 3296cd0ab96fe3b38a3892a434c47115c3fd271b..5596d0fa171a196a387cdb9770620b13f401cad8 100644
--- a/common/logging/fields_test.go
+++ b/common/logging/fields_test.go
@@ -128,17 +128,7 @@ func TestFields(t *testing.T) {
})
Convey(`Has a String representation: {"baz":"qux", "foo":"bar"}`, func() {
- So(fm.FieldString(false), ShouldEqual, `{"baz":"qux", "foo":"bar"}`)
- })
-
- Convey(`With a FilterOn key`, func() {
- fm = fm.Copy(Fields{
- FilterOnKey: "test",
- })
-
- Convey(`Has a pruned String representation: {"baz":"qux", "foo":"bar"}`, func() {
- So(fm.FieldString(true), ShouldEqual, `{"baz":"qux", "foo":"bar"}`)
- })
+ So(fm.String(), ShouldEqual, `{"baz":"qux", "foo":"bar"}`)
})
})
}
« no previous file with comments | « common/logging/fields.go ('k') | common/logging/filter.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698