Issue 16208004: No need to store invalid media queries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16208004: No need to store invalid media queries. (Closed)

Created:
7 years, 6 months ago by rune

Modified:
7 years, 6 months ago

Reviewers:
apavlov, jochen (gone - plz use gerrit), kenneth.r.christiansen

CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, kenneth.christiansen, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

No need to store invalid media queries. Stop creating media query expressions when a media query expression with an invalid value is encountered. Will result in storing a "not all" query instead. Had to add some braces due to new coding style enforcement for if-else. No tests added as invalid values and no values where values are required are covered by existing tests. BUG=248860 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152279

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+71 lines, -91 lines)			Patch
M	Source/core/css/CSSGrammar.y.in	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/css/MediaList.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/MediaQuery.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	Source/core/css/MediaQuery.cpp	View	4 chunks	+25 lines, -36 lines	0 comments	Download
M	Source/core/css/MediaQueryEvaluator.cpp	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	Source/core/css/MediaQueryExp.h	View	3 chunks	+2 lines, -5 lines	0 comments	Download
M	Source/core/css/MediaQueryExp.cpp	View	2 chunks	+41 lines, -41 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/16208004/1

7 years, 6 months ago (2013-06-12 11:57:48 UTC) #5

Message was sent while issue was closed.

Change committed as 152279

Expand Messages | Collapse Messages