Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Unified Diff: Source/core/css/MediaQueryExp.h

Issue 16208004: No need to store invalid media queries. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/MediaQueryEvaluator.cpp ('k') | Source/core/css/MediaQueryExp.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/MediaQueryExp.h
diff --git a/Source/core/css/MediaQueryExp.h b/Source/core/css/MediaQueryExp.h
index 5d15a8c7dae9d666e37eff2aca801f931a3a583f..9166e6555004c3bea0975d100e9a4ad80ce7bdcb 100644
--- a/Source/core/css/MediaQueryExp.h
+++ b/Source/core/css/MediaQueryExp.h
@@ -41,7 +41,7 @@ class CSSParserValueList;
class MediaQueryExp {
WTF_MAKE_FAST_ALLOCATED;
public:
- static PassOwnPtr<MediaQueryExp> create(const AtomicString& mediaFeature, CSSParserValueList* values);
+ static PassOwnPtr<MediaQueryExp> create(const AtomicString& mediaFeature, CSSParserValueList*);
~MediaQueryExp();
AtomicString mediaFeature() const { return m_mediaFeature; }
@@ -55,8 +55,6 @@ public:
|| (other.m_value && m_value && other.m_value->equals(*m_value)));
}
- bool isValid() const { return m_isValid; }
-
bool isViewportDependent() const;
String serialize() const;
@@ -66,11 +64,10 @@ public:
void reportMemoryUsage(MemoryObjectInfo*) const;
private:
- MediaQueryExp(const AtomicString& mediaFeature, CSSParserValueList* values);
+ MediaQueryExp(const AtomicString& mediaFeature, PassRefPtr<CSSValue>);
AtomicString m_mediaFeature;
RefPtr<CSSValue> m_value;
- bool m_isValid;
};
} // namespace
« no previous file with comments | « Source/core/css/MediaQueryEvaluator.cpp ('k') | Source/core/css/MediaQueryExp.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698