Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: Source/core/css/MediaList.cpp

Issue 16208004: No need to store invalid media queries. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/CSSGrammar.y.in ('k') | Source/core/css/MediaQuery.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * (C) 1999-2003 Lars Knoll (knoll@kde.org) 2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2006, 2010, 2012 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2006, 2010, 2012 Apple Inc. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 272 matching lines...) Expand 10 before | Expand all | Expand 10 after
283 return; 283 return;
284 284
285 const Vector<OwnPtr<MediaQuery> >& mediaQueries = mediaQuerySet->queryVector (); 285 const Vector<OwnPtr<MediaQuery> >& mediaQueries = mediaQuerySet->queryVector ();
286 const size_t queryCount = mediaQueries.size(); 286 const size_t queryCount = mediaQueries.size();
287 287
288 if (!queryCount) 288 if (!queryCount)
289 return; 289 return;
290 290
291 for (size_t i = 0; i < queryCount; ++i) { 291 for (size_t i = 0; i < queryCount; ++i) {
292 const MediaQuery* query = mediaQueries[i].get(); 292 const MediaQuery* query = mediaQueries[i].get();
293 if (query->ignored() || equalIgnoringCase(query->mediaType(), "print")) 293 if (equalIgnoringCase(query->mediaType(), "print"))
294 continue; 294 continue;
295 295
296 const Vector<OwnPtr<MediaQueryExp> >* exps = query->expressions(); 296 const Vector<OwnPtr<MediaQueryExp> >* exps = query->expressions();
297 for (size_t j = 0; j < exps->size(); ++j) { 297 for (size_t j = 0; j < exps->size(); ++j) {
298 const MediaQueryExp* exp = exps->at(j).get(); 298 const MediaQueryExp* exp = exps->at(j).get();
299 if (isResolutionMediaFeature(exp->mediaFeature())) { 299 if (isResolutionMediaFeature(exp->mediaFeature())) {
300 CSSValue* cssValue = exp->value(); 300 CSSValue* cssValue = exp->value();
301 if (cssValue && cssValue->isPrimitiveValue()) { 301 if (cssValue && cssValue->isPrimitiveValue()) {
302 CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(cssV alue); 302 CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(cssV alue);
303 if (primitiveValue->isDotsPerInch() || primitiveValue->isDot sPerCentimeter()) 303 if (primitiveValue->isDotsPerInch() || primitiveValue->isDot sPerCentimeter())
304 addResolutionWarningMessageToConsole(document, mediaQuer ySet->mediaText(), primitiveValue); 304 addResolutionWarningMessageToConsole(document, mediaQuer ySet->mediaText(), primitiveValue);
305 } 305 }
306 } 306 }
307 } 307 }
308 } 308 }
309 } 309 }
310 310
311 } 311 }
OLDNEW
« no previous file with comments | « Source/core/css/CSSGrammar.y.in ('k') | Source/core/css/MediaQuery.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698