Issue 16105012: Unrevert "[Sync] Split GetPreferredTypes into GetActiveType...""

Issue 16105012: Unrevert "[Sync] Split GetPreferredTypes into GetActiveType..."" (Closed)

Created:
7 years, 6 months ago by Nicolas Zea

Modified:
7 years, 6 months ago

Reviewers:
rlarocque

CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, akalin, Raghu Simha, browser-components-watch_chromium.org, tzik+watch_chromium.org, estade+watch_chromium.org, haitaol1, kinuko+watch, tim (not reviewing), pedrosimonetti+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Unrevert "[Sync] Split GetPreferredTypes into GetActiveType..."" Original codereview at https://codereview.chromium.org/14789020/ This fixes the win_aura failure from the original patch. BUG=none TBR=dbeam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203900

Patch Set 1 #

Patch Set 2 : Adjust mock #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -31 lines)			Patch
M	chrome/browser/history/web_history_service_factory.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/password_manager/password_generation_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/password_manager/password_generation_manager_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/failed_datatypes_handler.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_service.h	View		3 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View		10 chunks	+17 lines, -17 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_android.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_service_base.h	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_harness.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_mock.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/sync_file_system/sync_file_system_service.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/ntp/foreign_session_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/sync_setup_handler_unittest.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Nicolas Zea

PTAL. Adjusting the mocks is my best guess as to what might be going on, ...

7 years, 6 months ago (2013-06-03 23:02:40 UTC) #1

rlarocque

On 2013/06/03 23:02:40, Nicolas Zea wrote: > PTAL. Adjusting the mocks is my best guess ...

7 years, 6 months ago (2013-06-03 23:22:41 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/16105012/3001

7 years, 6 months ago (2013-06-03 23:28:44 UTC) #3

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=6518

7 years, 6 months ago (2013-06-03 23:37:59 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/16105012/3001

7 years, 6 months ago (2013-06-04 00:37:08 UTC) #5

Message was sent while issue was closed.

Change committed as 203900

Expand Messages | Collapse Messages