Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5489)

Unified Diff: chrome/browser/sync/profile_sync_service.h

Issue 16105012: Unrevert "[Sync] Split GetPreferredTypes into GetActiveType..."" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adjust mock Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/failed_datatypes_handler.cc ('k') | chrome/browser/sync/profile_sync_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/profile_sync_service.h
diff --git a/chrome/browser/sync/profile_sync_service.h b/chrome/browser/sync/profile_sync_service.h
index c8f8e0396766ba4dfb2d8e772ad8b20f3696637c..a42cf167e9f3db3c56a73c36f8a1778bea739800 100644
--- a/chrome/browser/sync/profile_sync_service.h
+++ b/chrome/browser/sync/profile_sync_service.h
@@ -126,6 +126,7 @@ class EncryptedData;
// Additionally, the current sync configuration can be fetched by calling
// * GetRegisteredDataTypes()
// * GetPreferredDataTypes()
+// * GetActiveDataTypes()
// * IsUsingSecondaryPassphrase()
// * EncryptEverythingEnabled()
// * IsPassphraseRequired()/IsPassphraseRequiredForDecryption()
@@ -233,7 +234,7 @@ class ProfileSyncService : public ProfileSyncServiceBase,
// ProfileSyncServiceBase implementation.
virtual bool HasSyncSetupCompleted() const OVERRIDE;
virtual bool ShouldPushChanges() OVERRIDE;
- virtual syncer::ModelTypeSet GetPreferredDataTypes() const OVERRIDE;
+ virtual syncer::ModelTypeSet GetActiveDataTypes() const OVERRIDE;
virtual void AddObserver(Observer* observer) OVERRIDE;
virtual void RemoveObserver(Observer* observer) OVERRIDE;
virtual bool HasObserver(Observer* observer) const OVERRIDE;
@@ -499,6 +500,10 @@ class ProfileSyncService : public ProfileSyncServiceBase,
virtual void ChangePreferredDataTypes(
syncer::ModelTypeSet preferred_types);
+ // Returns the set of types which are preferred for enabling. This is a
+ // superset of the active types (see GetActiveTypes()).
+ virtual syncer::ModelTypeSet GetPreferredDataTypes() const;
+
// Gets the set of all data types that could be allowed (the set that
// should be advertised to the user). These will typically only change
// via a command-line option. See class comment for more on what it means
« no previous file with comments | « chrome/browser/sync/failed_datatypes_handler.cc ('k') | chrome/browser/sync/profile_sync_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698