Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: chrome/browser/password_manager/password_generation_manager.cc

Issue 16105012: Unrevert "[Sync] Split GetPreferredTypes into GetActiveType..."" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adjust mock Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/password_manager/password_generation_manager.h" 5 #include "chrome/browser/password_manager/password_generation_manager.h"
6 6
7 #include "base/prefs/pref_service.h" 7 #include "base/prefs/pref_service.h"
8 #include "chrome/browser/password_manager/password_manager.h" 8 #include "chrome/browser/password_manager/password_manager.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/browser/sync/profile_sync_service.h" 10 #include "chrome/browser/sync/profile_sync_service.h"
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 bool saving_passwords_enabled = 123 bool saving_passwords_enabled =
124 PasswordManager::FromWebContents(web_contents())->IsSavingEnabled(); 124 PasswordManager::FromWebContents(web_contents())->IsSavingEnabled();
125 125
126 bool preference_checked = profile->GetPrefs()->GetBoolean( 126 bool preference_checked = profile->GetPrefs()->GetBoolean(
127 prefs::kPasswordGenerationEnabled); 127 prefs::kPasswordGenerationEnabled);
128 128
129 bool password_sync_enabled = false; 129 bool password_sync_enabled = false;
130 ProfileSyncService* sync_service = 130 ProfileSyncService* sync_service =
131 ProfileSyncServiceFactory::GetForProfile(profile); 131 ProfileSyncServiceFactory::GetForProfile(profile);
132 if (sync_service) { 132 if (sync_service) {
133 syncer::ModelTypeSet sync_set = sync_service->GetPreferredDataTypes(); 133 syncer::ModelTypeSet sync_set = sync_service->GetActiveDataTypes();
134 password_sync_enabled = (sync_service->HasSyncSetupCompleted() && 134 password_sync_enabled = (sync_service->HasSyncSetupCompleted() &&
135 sync_set.Has(syncer::PASSWORDS)); 135 sync_set.Has(syncer::PASSWORDS));
136 } 136 }
137 137
138 bool new_enabled = (password_sync_enabled && 138 bool new_enabled = (password_sync_enabled &&
139 saving_passwords_enabled && 139 saving_passwords_enabled &&
140 preference_checked); 140 preference_checked);
141 141
142 if (new_enabled != enabled_ || new_renderer) { 142 if (new_enabled != enabled_ || new_renderer) {
143 enabled_ = new_enabled; 143 enabled_ = new_enabled;
(...skipping 14 matching lines...) Expand all
158 #if defined(OS_ANDROID) 158 #if defined(OS_ANDROID)
159 NOTIMPLEMENTED(); 159 NOTIMPLEMENTED();
160 #else 160 #else
161 password_generator_.reset(new autofill::PasswordGenerator(max_length)); 161 password_generator_.reset(new autofill::PasswordGenerator(max_length));
162 Browser* browser = chrome::FindBrowserWithWebContents(web_contents()); 162 Browser* browser = chrome::FindBrowserWithWebContents(web_contents());
163 browser->window()->ShowPasswordGenerationBubble(bounds, 163 browser->window()->ShowPasswordGenerationBubble(bounds,
164 form, 164 form,
165 password_generator_.get()); 165 password_generator_.get());
166 #endif // #if defined(OS_ANDROID) 166 #endif // #if defined(OS_ANDROID)
167 } 167 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698