Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 16013003: Fix hole handling, and ensure smi representation is handled properly (Closed)

Created:
7 years, 7 months ago by Toon Verwaest
Modified:
7 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix hole handling, and ensure smi representation is handled properly R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14807

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -143 lines) Patch
M src/arm/lithium-arm.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/lithium-arm.cc View 7 chunks +10 lines, -23 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +4 lines, -16 lines 0 comments Download
M src/hydrogen-instructions.h View 3 chunks +7 lines, -1 line 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +4 lines, -16 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/lithium-ia32.cc View 15 chunks +21 lines, -37 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +4 lines, -16 lines 0 comments Download
M src/x64/lithium-x64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/lithium-x64.cc View 11 chunks +15 lines, -30 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 7 months ago (2013-05-24 13:30:02 UTC) #1
Jakob Kummerow
lgtm
7 years, 7 months ago (2013-05-24 13:37:58 UTC) #2
Toon Verwaest
7 years, 7 months ago (2013-05-24 13:40:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14807 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698