Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: src/hydrogen-instructions.cc

Issue 16013003: Fix hole handling, and ensure smi representation is handled properly (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2698 matching lines...) Expand 10 before | Expand all | Expand 10 after
2709 } 2709 }
2710 return true; 2710 return true;
2711 } 2711 }
2712 2712
2713 if (IsFastDoubleElementsKind(elements_kind())) { 2713 if (IsFastDoubleElementsKind(elements_kind())) {
2714 return false; 2714 return false;
2715 } 2715 }
2716 2716
2717 for (HUseIterator it(uses()); !it.Done(); it.Advance()) { 2717 for (HUseIterator it(uses()); !it.Done(); it.Advance()) {
2718 HValue* use = it.value(); 2718 HValue* use = it.value();
2719 if (!use->IsChange()) { 2719 if (!use->IsChange() || !HChange::cast(use)->to().IsDouble()) {
2720 return false; 2720 return false;
2721 } 2721 }
2722 } 2722 }
2723 2723
2724 return true; 2724 return true;
2725 } 2725 }
2726 2726
2727 2727
2728 bool HLoadKeyed::AllUsesCanTreatHoleAsNaN() const { 2728 bool HLoadKeyed::AllUsesCanTreatHoleAsNaN() const {
2729 if (!IsFastDoubleElementsKind(elements_kind())) { 2729 if (!IsFastDoubleElementsKind(elements_kind())) {
(...skipping 1065 matching lines...) Expand 10 before | Expand all | Expand 10 after
3795 case kBackingStore: 3795 case kBackingStore:
3796 if (!name_.is_null()) stream->Add(*String::cast(*name_)->ToCString()); 3796 if (!name_.is_null()) stream->Add(*String::cast(*name_)->ToCString());
3797 stream->Add("[backing-store]"); 3797 stream->Add("[backing-store]");
3798 break; 3798 break;
3799 } 3799 }
3800 3800
3801 stream->Add("@%d", offset()); 3801 stream->Add("@%d", offset());
3802 } 3802 }
3803 3803
3804 } } // namespace v8::internal 3804 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698