src/hydrogen-instructions.cc - Issue 16013003: Fix hole handling, and ensure smi representation is handled properly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen-instructions.cc

Issue 16013003: Fix hole handling, and ensure smi representation is handled properly (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen-instructions.cc

diff --git a/src/hydrogen-instructions.cc b/src/hydrogen-instructions.cc

index e949587a78fa7ace69ba7115603c536a59c0e713..050115e9be61db40272a0b0a26c98be92869d138 100644

--- a/src/hydrogen-instructions.cc

+++ b/src/hydrogen-instructions.cc

@@ -2716,7 +2716,7 @@ bool HLoadKeyed::UsesMustHandleHole() const {

for (HUseIterator it(uses()); !it.Done(); it.Advance()) {

HValue* use = it.value();

- if (!use->IsChange()) {

+ if (!use->IsChange() || !HChange::cast(use)->to().IsDouble()) {

return false;

}

« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »