Issue 15932011: Don't explicitly pass requested representations to constants; implement ConstantS

Issue 15932011: Don't explicitly pass requested representations to constants; implement ConstantS (Closed)

Created:
7 years, 6 months ago by Toon Verwaest

Modified:
7 years, 6 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Don't explicitly pass requested representations to constants; implement ConstantS R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14874

Patch Set 2 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+104 lines, -91 lines)			Patch
M	src/arm/lithium-arm.h	View		2 chunks	+10 lines, -0 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/code-stubs-hydrogen.cc	View		1 chunk	+3 lines, -6 lines	0 comments	Download
M	src/hydrogen.h	View		2 chunks	+3 lines, -6 lines	0 comments	Download
M	src/hydrogen.cc	View		21 chunks	+28 lines, -47 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		4 chunks	+4 lines, -13 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View		2 chunks	+9 lines, -10 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/ia32/lithium-ia32.h	View		2 chunks	+10 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/x64/lithium-x64.h	View		2 chunks	+10 lines, -0 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM https://chromiumcodereview.appspot.com/15932011/diff/31/src/hydrogen-instructions.h File src/hydrogen-instructions.h (left): https://chromiumcodereview.appspot.com/15932011/diff/31/src/hydrogen-instructions.h#oldcode3530 src/hydrogen-instructions.h:3530: enum BoundsCheckKeyMode { Yay! Clean up ALL the ...

7 years, 6 months ago (2013-05-29 10:12:53 UTC) #2

Toon Verwaest

7 years, 6 months ago (2013-05-29 10:48:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r14874 (presubmit successful).

Expand Messages | Collapse Messages