src/ia32/lithium-codegen-ia32.cc - Issue 15932011: Don't explicitly pass requested representations to constants; implement ConstantS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/lithium-codegen-ia32.cc

Issue 15932011: Don't explicitly pass requested representations to constants; implement ConstantS (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/lithium-codegen-ia32.cc

diff --git a/src/ia32/lithium-codegen-ia32.cc b/src/ia32/lithium-codegen-ia32.cc

index 46dcec0d8804b66d808c024b75825cb18b23c637..a02d3ce1d281c3a5995172637dc0c2168575ce9c 100644

--- a/src/ia32/lithium-codegen-ia32.cc

+++ b/src/ia32/lithium-codegen-ia32.cc

@@ -1751,7 +1751,11 @@ void LCodeGen::DoSubI(LSubI* instr) {

void LCodeGen::DoConstantI(LConstantI* instr) {

- ASSERT(instr->result()->IsRegister());

+ __ Set(ToRegister(instr->result()), Immediate(instr->value()));

+void LCodeGen::DoConstantS(LConstantS* instr) {

__ Set(ToRegister(instr->result()), Immediate(instr->value()));

}

« no previous file with comments | « src/hydrogen-instructions.cc ('k') | src/ia32/lithium-ia32.h » ('j') | no next file with comments »