Don't explicitly pass requested representations to constants; implement ConstantS

src/ia32/lithium-codegen-ia32.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1738 matching lines @@
   }
 }
 
 
 void LCodeGen::DoConstantI(LConstantI* instr) {
   ASSERT(instr->result()->IsRegister());
   __ Set(ToRegister(instr->result()), Immediate(instr->value()));
 }
 
 
+void LCodeGen::DoConstantS(LConstantS* instr) {
+  ASSERT(instr->result()->IsRegister());

[Jakob Kummerow, 2013/05/29 10:12:53]

We don't need this ASSERT; ToRegister(foo) does an ASSERT(foo->IsRegister())
anyway. Feel free to remove it from DoConstantI as well.

+  __ Set(ToRegister(instr->result()), Immediate(instr->value()));
+}
+
+
 void LCodeGen::DoConstantD(LConstantD* instr) {
   double v = instr->value();
   uint64_t int_val = BitCast<uint64_t, double>(v);
   int32_t lower = static_cast<int32_t>(int_val);
   int32_t upper = static_cast<int32_t>(int_val >> (kBitsPerInt));
 
   if (!CpuFeatures::IsSafeForSnapshot(SSE2)) {
     __ push(Immediate(lower));
     __ push(Immediate(upper));
     PushX87DoubleOperand(Operand(esp, 0));
@@ skipping 4812 matching lines @@
                               FixedArray::kHeaderSize - kPointerSize));
   __ bind(&done);
 }
 
 
 #undef __
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_IA32