Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1464)

Issue 15884002: Require smi for keyed store to smi. (Closed)

Created:
7 years, 7 months ago by Toon Verwaest
Modified:
7 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update ASSERT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M src/arm/lithium-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 7 months ago (2013-05-23 14:54:04 UTC) #1
Jakob Kummerow
lgtm
7 years, 7 months ago (2013-05-23 14:55:37 UTC) #2
Toon Verwaest
7 years, 7 months ago (2013-05-23 15:01:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r14779 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698