Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 15884002: Require smi for keyed store to smi. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Update ASSERT Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2326 matching lines...) Expand 10 before | Expand all | Expand 10 after
2337 LOperand* object = UseRegisterAtStart(instr->elements()); 2337 LOperand* object = UseRegisterAtStart(instr->elements());
2338 LOperand* val = NULL; 2338 LOperand* val = NULL;
2339 if (CpuFeatures::IsSafeForSnapshot(SSE2)) { 2339 if (CpuFeatures::IsSafeForSnapshot(SSE2)) {
2340 val = UseRegisterAtStart(instr->value()); 2340 val = UseRegisterAtStart(instr->value());
2341 } else if (!instr->IsConstantHoleStore()) { 2341 } else if (!instr->IsConstantHoleStore()) {
2342 val = UseX87TopOfStack(instr->value()); 2342 val = UseX87TopOfStack(instr->value());
2343 } 2343 }
2344 LOperand* key = UseRegisterOrConstantAtStart(instr->key()); 2344 LOperand* key = UseRegisterOrConstantAtStart(instr->key());
2345 return new(zone()) LStoreKeyed(object, key, val); 2345 return new(zone()) LStoreKeyed(object, key, val);
2346 } else { 2346 } else {
2347 ASSERT(instr->value()->representation().IsTagged()); 2347 ASSERT(instr->value()->representation().IsSmiOrTagged());
2348 bool needs_write_barrier = instr->NeedsWriteBarrier(); 2348 bool needs_write_barrier = instr->NeedsWriteBarrier();
2349 2349
2350 LOperand* obj = UseRegister(instr->elements()); 2350 LOperand* obj = UseRegister(instr->elements());
2351 LOperand* val; 2351 LOperand* val;
2352 LOperand* key; 2352 LOperand* key;
2353 if (needs_write_barrier) { 2353 if (needs_write_barrier) {
2354 val = UseTempRegister(instr->value()); 2354 val = UseTempRegister(instr->value());
2355 key = UseTempRegister(instr->key()); 2355 key = UseTempRegister(instr->key());
2356 } else { 2356 } else {
2357 val = UseRegisterOrConstantAtStart(instr->value()); 2357 val = UseRegisterOrConstantAtStart(instr->value());
(...skipping 441 matching lines...) Expand 10 before | Expand all | Expand 10 after
2799 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2799 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2800 LOperand* object = UseRegister(instr->object()); 2800 LOperand* object = UseRegister(instr->object());
2801 LOperand* index = UseTempRegister(instr->index()); 2801 LOperand* index = UseTempRegister(instr->index());
2802 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2802 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2803 } 2803 }
2804 2804
2805 2805
2806 } } // namespace v8::internal 2806 } } // namespace v8::internal
2807 2807
2808 #endif // V8_TARGET_ARCH_IA32 2808 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698