Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 15884002: Require smi for keyed store to smi. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Update ASSERT Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen-instructions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2234 matching lines...) Expand 10 before | Expand all | Expand 10 after
2245 bool needs_write_barrier = instr->NeedsWriteBarrier(); 2245 bool needs_write_barrier = instr->NeedsWriteBarrier();
2246 LOperand* object = NULL; 2246 LOperand* object = NULL;
2247 LOperand* key = NULL; 2247 LOperand* key = NULL;
2248 LOperand* val = NULL; 2248 LOperand* val = NULL;
2249 2249
2250 if (instr->value()->representation().IsDouble()) { 2250 if (instr->value()->representation().IsDouble()) {
2251 object = UseRegisterAtStart(instr->elements()); 2251 object = UseRegisterAtStart(instr->elements());
2252 val = UseTempRegister(instr->value()); 2252 val = UseTempRegister(instr->value());
2253 key = UseRegisterOrConstantAtStart(instr->key()); 2253 key = UseRegisterOrConstantAtStart(instr->key());
2254 } else { 2254 } else {
2255 ASSERT(instr->value()->representation().IsTagged()); 2255 ASSERT(instr->value()->representation().IsSmiOrTagged());
2256 object = UseTempRegister(instr->elements()); 2256 object = UseTempRegister(instr->elements());
2257 val = needs_write_barrier ? UseTempRegister(instr->value()) 2257 val = needs_write_barrier ? UseTempRegister(instr->value())
2258 : UseRegisterAtStart(instr->value()); 2258 : UseRegisterAtStart(instr->value());
2259 key = needs_write_barrier ? UseTempRegister(instr->key()) 2259 key = needs_write_barrier ? UseTempRegister(instr->key())
2260 : UseRegisterOrConstantAtStart(instr->key()); 2260 : UseRegisterOrConstantAtStart(instr->key());
2261 } 2261 }
2262 2262
2263 return new(zone()) LStoreKeyed(object, key, val); 2263 return new(zone()) LStoreKeyed(object, key, val);
2264 } 2264 }
2265 2265
(...skipping 380 matching lines...) Expand 10 before | Expand all | Expand 10 after
2646 2646
2647 2647
2648 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2648 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2649 LOperand* object = UseRegister(instr->object()); 2649 LOperand* object = UseRegister(instr->object());
2650 LOperand* index = UseRegister(instr->index()); 2650 LOperand* index = UseRegister(instr->index());
2651 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2651 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2652 } 2652 }
2653 2653
2654 2654
2655 } } // namespace v8::internal 2655 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen-instructions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698